Bug 146608

Summary:	Powersave polutes syslog when CPU doesn't support frequency scaling
Product:	[openSUSE] SUSE Linux 10.1	Reporter:	Forgotten User 55iwwMllzz <forgotten_55iwwMllzz>
Component:	Other	Assignee:	Holger Macht <hmacht>
Status:	VERIFIED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Minor
Priority:	P5 - None
Version:	Beta 2
Target Milestone:	---
Hardware:	All
OS:	Other
Whiteboard:
Found By:	Beta-Customer	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Forgotten User 55iwwMllzz 2006-01-30 14:16:41 UTC

Since my laptop processor does not support frequency scaling (it's an Intel Celeron), Powersave sends the same warnings and errors to syslog everytime there is battery charging state event:

[powersave]: WARNING (getCoresAffectedCpus:251) failed to get affected_cpus for cpu 0
[powersave]: WARNING (getCoresAffectedCpus:251) failed to get affected_cpus for cpu 0
[powersave]: ERROR (read_line:118) Could not open '/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor': No such file or directory
[powersave]: WARNING (initSingleInterface:102) Kernel ondemand governor not working, trying userspace instead
[powersave]: ERROR (read_line:118) Could not open '/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor': No such file or directory
[powersave]: WARNING (initSingleInterface:91) Could not init userspace governor
[powersave]: ERROR (initSingleInterface:104) Neither ondemand nor userspace governor working

I have set CPUFREQ_ENABLED="off" in /etc/sysconfig/powersave/cpufreq (and afterwards ran SuSEconfig and restarted Powersave) but still the same messages are sent to syslog. 
Couldn't Powersave send those messages only when it starts, instead of each time the battery charging state changes?

Comment 1 Thomas Renninger 2006-01-30 15:16:55 UTC

This should already be fixed.
Reassigning to Holger just to be sure.

Comment 2 Holger Macht 2006-01-30 15:20:12 UTC

Yes, the warning should not appear in newer version. But I have to look why CPUFREQ_ENABLED="off" does not have any effect.

Comment 3 Holger Macht 2006-01-31 09:25:56 UTC

It has to be CPUFREQ_ENABLED="no", but its functionality was corrupted anyway. Fixed in svn.

Comment 4 Forgotten User 55iwwMllzz 2006-01-31 12:02:00 UTC

> It has to be CPUFREQ_ENABLED="no", but its functionality was corrupted anyway.

From your comment I presume that, even after the fix, the user will still need to manually edit /etc/sysconfig/powersave/cpufreq and change CPUFREQ_ENABLED?
If so, couldn't Powersave notice the processor does not support frequency scaling and automatically assume CPUFREQ_ENABLED="no"? (or show a warning only when it starts, but not on every battery state change?)

Comment 5 Holger Macht 2006-01-31 12:13:02 UTC

With the fix only one warning on daemon startup will be shown. Please reopen if that's not the case with beta3.

Unfortunatelly, the fix for the CPUFREQ_ENABLED variable won't make it into beta4.