Bug 146687

Summary:	Radeon DRM driver patch
Product:	[openSUSE] SUSE Linux 10.1	Reporter:	Stefan Dirsch <sndirsch>
Component:	Kernel	Assignee:	Greg Kroah-Hartman <gregkh>
Status:	RESOLVED WONTFIX	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	eich, kernel01, suse-beta
Version:	Beta 2
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	Current DRM patch by Benjamin Patch against kernel-source of 10.1 Beta3

Description Stefan Dirsch 2006-01-30 17:13:41 UTC

As you can see in Bug #127757, we (SuSE/Novell/X.Org) currently have big problems with the radeon driver in general. Benjamin Herrenschmidt has been working hard to adress theses issues and generated patches for X and Kernel accordingly. We already include the X driver patch for Beta3.

===============================================================================
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Discuss issues related to the xorg tree <xorg@lists.freedesktop.org>
Date: Thu, 26 Jan 2006 10:43:39 +1100
Cc: dri-devel@lists.sourceforge.net
Subject: [PATCH] new radeon memory map fixes

Ok, so finally here is a new version of the patch. This time, it's
against modular and it comes with a DRM patch. The X driver and the DRM
patch should both work with the unpatched counterpart though you'll only
get the full benefit of the fixes with both patches applied.

As I had to shuffle a lot of code around in the X driver, there may
still be bugs lurking around. Especially look for regressions around
Xinerama and MergedFB as I haven't yet had a chance to test with those
(especially Xinerama is doing a lot of very dodgy stuffs in the radeon
driver).

Please, try to test all sort of combinations of color tiling on/off, dri
enabled/disabled, bit depth, hw/sw cursor etc...

Patches are available at:

Xorg driver patch:
http://gate.crashing.org/~benh/radeon-memmap-7.0-2.diff

DRM patch:
http://gate.crashing.org/~benh/radeon-memmap-drm-1.diff

Please, report any problem,
thanks,

Ben.
===============================================================================

Could you apply the DRM patch to the SUSE kernel? Ben has got several 
positive feedback mails. Therefore I don't think that this patch will 
break any things.

The DRM patch has been updated meanwhile (radeon-memmap-drm-3.diff). Unfortunately the patch is against DRM CVS and would need to be ported back to the DRM sources in the current kernel (probably a trivial task). :-(

Comment 1 Stefan Dirsch 2006-01-30 17:25:50 UTC

Created attachment 65719 [details]
Current DRM patch by Benjamin

Comment 2 Stefan Dirsch 2006-02-02 09:53:59 UTC

Created attachment 66151 [details]
Patch against kernel-source of 10.1 Beta3

Comment 3 Greg Kroah-Hartman 2006-02-09 01:37:30 UTC

Are these patches accepted by upstream yet?

Comment 4 Stefan Dirsch 2006-02-09 08:52:33 UTC

I don't know. At least the patch is no yet in DRM CVS. Proably this needs to be discussed with Benjamin and Dave Airlie <airlied@gmail.com>. AFAIK he synchronizes the DRM CVS and upstream kernel sources.

Comment 5 Greg Kroah-Hartman 2006-02-09 21:52:08 UTC

Yes, he does.  Please discuss it with him, and find out the acceptance of it.

We don't want to carry around such a patch for the next 7 years unless we know
it's accepted into mainline...

Comment 6 Stefan Dirsch 2006-02-09 22:47:15 UTC

done. I've included you in Cc ...

Comment 10 Stefan Dirsch 2006-02-10 09:46:53 UTC

Greg, as you can see there's nothing to do on your side for now. I'll keep you up-to-date. Bugreport remains therefore on status "NEEDINFO".

Comment 11 Greg Kroah-Hartman 2006-02-13 22:11:15 UTC

Due to the immature state of this patch set, I really do not think we can 
accept it at this late stage, sorry.

We are _way_ past the "add new features" deadline...

Comment 13 Stefan Dirsch 2006-02-17 07:20:32 UTC

The patch has not been committed yet to DRM CVS. I'll keep you up-to-date.

Comment 14 Stefan Dirsch 2006-02-19 23:05:24 UTC

Small update. Dave Airlie finally committed benh's memory management patch
to DRM CVS (2006-02-18/2006-02-19).

--> http://gate.crashing.org/~benh/radeon-memmap-drm-5.diff

Comment 15 Olaf Kirch 2006-03-06 14:55:54 UTC

Greg, care for a little bit of DRM fun? :-)

Comment 16 Greg Kroah-Hartman 2006-03-06 15:52:46 UTC

Sure, I'll take it, but it should still be NEEDINFO, as I don't want to 
add such a big change so late in the cycle...

Comment 17 Stefan Dirsch 2006-03-06 15:58:27 UTC

Of course. Only apply it when it has been committed upstream. Unfortunately I probably won't notice when it gets committed upstream. :-(

Comment 18 Stefan Dirsch 2006-03-26 08:54:50 UTC

Still not upstream (checked 2.6.16). Anyway, it's way to late for 10.1. Closing as WONTFIX.