Bug 147377

Summary: installation -> system repair doesn't handle LVM volumes
Product: [openSUSE] SUSE Linux 10.1 Reporter: Carl-Daniel Hailfinger <kernel01>
Component: InstallationAssignee: Jiří Suchomel <jsuchome>
Status: RESOLVED FIXED QA Contact: Klaus Kämpf <kkaempf>
Severity: Normal    
Priority: P5 - None CC: axel.braun, stefan.fent
Version: Beta 3   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Development Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: y2logs
log after repair on LVM
patch for /usr/share/YaST2/modules/OSRFstab.ycp
YaST2 logs after repair with applied patch
once again....with
package for testing
Log files w ext. logging
new package
log files

Description Carl-Daniel Hailfinger 2006-02-01 19:54:07 UTC
I do have a few old installations lying around, however my current beta3 install is on LVM. If I select "system repair" at the installation screen, all partitions are checked, however no LVM volume is checked. Even worse, at one point I'm forced to select the correct root partition, but since it is on LVM it is not listed and I only have an OK button.

y2logs follow.
Comment 1 Carl-Daniel Hailfinger 2006-02-01 19:57:13 UTC
Created attachment 66085 [details]
y2logs
Comment 2 Michael Gross 2006-02-01 21:08:08 UTC
Please attach the output of `fdisk -l'.
Comment 3 Carl-Daniel Hailfinger 2006-02-01 21:28:07 UTC
This is already in the tarball (it has everything in /var/log/YaST2).
Comment 4 Michael Gross 2006-02-02 12:20:02 UTC
Is this another system than in bug #147366?
Please also attach the required files here (`fdisk -l', vgscan, resulting fstab).
Comment 5 Michael Gross 2006-02-03 13:31:49 UTC
Ok, I talked to the maintainer. Please provde more information about your LVM-configuration here.
Comment 6 Carl-Daniel Hailfinger 2006-02-03 15:23:27 UTC
This is the same system as in bug #147366. Please look at attachment 66368 [details] which should contain all the info you need.

fdisk-l_hda
fdisk-l_hdb
lvdisplay.txt
pvdisplay.txt
vgdisplay.txt
Comment 7 Thomas Renninger 2006-02-13 08:20:48 UTC
Reassign to Yast developer...
Adding sf to CC in case this could have something to do with recent bootloader changes ...
Comment 8 Thomas Fehr 2006-03-13 11:55:24 UTC
Reassigned to maintainer of yast2-repair.
Comment 9 Jiří Suchomel 2006-03-13 11:58:23 UTC
*** Bug 156602 has been marked as a duplicate of this bug. ***
Comment 10 Jiří Suchomel 2006-03-14 10:01:02 UTC
The log file doesn't include any antry from yast2-repair module. Please try running it on installed system ('/sbin/yast2 repair'), if it doesn't handle LVM correctly, it should be seen on installed system as well.

Provide correct logs after that (Carl-Daniel or Alex)
Comment 11 Axel Braun 2006-03-14 16:16:54 UTC
Hi Jiri,
what log are you looking for? I run the repair on a running system, but there is no file in /var/log/yast2 that would match the time the repair was running
Comment 12 Axel Braun 2006-03-14 16:24:11 UTC
Created attachment 72819 [details]
log after repair on LVM

OK, running it as root provided the needed log :-)
Comment 13 Jiří Suchomel 2006-03-15 10:24:10 UTC
Created attachment 72965 [details]
patch for /usr/share/YaST2/modules/OSRFstab.ycp

Alex, please patch your /usr/share/YaST2/modules/OSRFstab.ycp with this patch, call 'ycpc -c /usr/share/YaST2/modules/OSRFstab.ycp', run yast2-repair again (preferably with LANG=C) and attach the new logfiles (better the whole /var/log/YaST2 directory than just y2log)
Comment 14 Jiří Suchomel 2006-03-15 10:25:13 UTC
(Sorry for "Alex"m I mean Axel)
Comment 15 Axel Braun 2006-03-15 12:19:40 UTC
> (Sorry for "Alex"m I mean Axel)
not the first time :-)
z60m:/usr/share/YaST2/modules # patch -p0 OSRFstab.ycp /home/axel/OSRFstab.diff
patching file OSRFstab.ycp
Hunk #1 succeeded at 249 with fuzz 1 (offset -1 lines).
Hunk #2 succeeded at 298 (offset -2 lines).
Hunk #3 succeeded at 329 (offset -2 lines).
Hunk #4 succeeded at 338 (offset -2 lines).
Hunk #5 succeeded at 365 (offset -2 lines).
z60m:/usr/share/YaST2/modules # /sbin/yast2 repair

-> didnt find root partition again
Comment 16 Axel Braun 2006-03-15 12:21:05 UTC
Created attachment 72996 [details]
YaST2 logs after repair with applied patch
Comment 17 Jiří Suchomel 2006-03-15 12:33:15 UTC
Sorry, by could you try again without forgetting to call 'ycpc -c /usr/share/YaST2/modules/OSRFstab.ycp'? From these logs it looks like you forgot to do so...

> -> didnt find root partition again

I added only more logging informations, so yes, it will fail again.
Comment 18 Axel Braun 2006-03-15 12:43:25 UTC
Created attachment 73003 [details]
once again....with
Comment 19 Jiří Suchomel 2006-03-16 08:47:32 UTC
Created attachment 73260 [details]
package for testing

I'm still bit confused by some parts of the logs. Let's do another test: here is the package, adding even more logging. Please install it, run again 'yast2 repair' and attach the logs afterwards.
Comment 20 Jiří Suchomel 2006-03-16 08:49:02 UTC
And please, run the module with 'LANG=C yast2 repair' or 'LANG=en_US yast2 repair', so there are not german messages in the log.
Comment 21 Axel Braun 2006-03-16 10:00:56 UTC
Created attachment 73285 [details]
Log files w ext. logging

Hope it worked this time with the language
Comment 22 Jiří Suchomel 2006-03-17 09:14:40 UTC
The root partition (on LVM) has this description:

$["detected_fs":`reiser, "device":"/dev/z60system/root", "fstopt":"acl,user_xattr", "fstype":"LV", "mount":"/", "name":"root", "size_k":8388608, "stripes":1, "type":`lvm, "used_fs":`reiser, "uuid":"7d41d493-ff92-4cdf-bec4-09197c130f43"]

(y2log line 7080)

It's a submap of "partitions" list from Storage::GetTargetMap() for /dev/z60system device.

Thomas, why the partition map doesn't include "fsid" key?
Comment 23 Thomas Fehr 2006-03-17 12:27:55 UTC
The fsid key is only present for partitions of a real disk.
It contains the partition id from a msdos partitions table (e.g. 0x83 for linux
partitions, 0x82 for swap partitions).
LVM volumes, Software Raids and other such artificial entities do not have
such a fsid (maybe this is a change in comparison to pre-code10 maps). 
Comment 24 Jiří Suchomel 2006-03-17 13:14:24 UTC
Created attachment 73689 [details]
new package

OK; let's try again with this package
Comment 25 Axel Braun 2006-03-17 14:40:24 UTC
Created attachment 73697 [details]
log files

Looks good - root partition recognized and mounted!
Comment 26 Jiří Suchomel 2006-03-20 10:20:51 UTC
ok, fixed