Bug 148646

Summary:	NetworkManager: random bytes inserted into SSID (buffer overrun?)
Product:	[openSUSE] SUSE Linux 10.1	Reporter:	Forgotten User ZhJd0F0L3x <forgotten_ZhJd0F0L3x>
Component:	Network	Assignee:	Robert Love <rml>
Status:	VERIFIED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Blocker
Priority:	P5 - None	CC:	deckel
Version:	Beta 3
Target Milestone:	Beta 4
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Component Test	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	140732
Attachments:	Trivial patch, this should fix it.

Comment 2 Forgotten User ZhJd0F0L3x 2006-02-07 11:17:30 UTC

The cipher_bin2hexstr has an offbyone in malloc - leading to a missing string-terminator. Whoever wrote this, please put a brown paper bag on your head or bring a case of franconian beer to my office (preferred).

Maybe the return value of malloc also should be subject to further scrutiny, but i am not familiar with g_malloc0, maybe this already takes care of everything.

BTW: after analyzing my logs, this might account to many of the mysterious random failures, where i always thought that just the timeout was too small.

Comment 3 Forgotten User ZhJd0F0L3x 2006-02-07 11:19:31 UTC

Created attachment 66704 [details]
Trivial patch, this should fix it.

Comment 4 Forgotten User ZhJd0F0L3x 2006-02-07 11:59:47 UTC

Bart, after looking at the code, this might also help with your WEP problems.

Comment 5 Robert Love 2006-02-07 15:50:42 UTC

Nice catch, seife.  Also nice work tracking down the specific bug.

Submitted fix to CVS and updated package (20060207) to autobuild.

Everyone: Please retest any problems you have add with the previous versions and update your bugs!

Comment 6 Bart Whiteley 2006-02-08 02:49:56 UTC

Sorry.  This didn't fix my bug (#144268)

Comment 7 Forgotten User ZhJd0F0L3x 2006-06-13 10:46:32 UTC

works in 10.1 final