Bug 150400

Summary: glade-2.12.1-4: dodgy code
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: E-mail List <bnc-team-screening>
Status: RESOLVED INVALID QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2006-02-13 13:28:18 UTC
I just tried to compile package glade-2.12.1-4 with the Intel C compiler.

It said

gbwidget.c(405): warning #187: use of "=" where "==" may have been intended

The source code is

    g_return_val_if_fail ((new_widget = NULL), NULL);

Suggest code rework. Maybe the programmer intended

    g_return_val_if_fail ((new_widget == NULL), NULL);
Comment 1 Michael Gross 2006-02-13 13:48:05 UTC
David: Please don't report these issues unless there is an actual problem. Specially don't report warnings from icc, SUSE Linux is getting compiled with gcc.

And as the compiler says correctly here: It _may_ have.