|
Bugzilla – Full Text Bug Listing |
| Summary: | xzgv --exif-orient doesn't work | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.3 | Reporter: | Harald Koenig <koenig> |
| Component: | X11 Applications | Assignee: | Joerg Reuter <jreuter> |
| Status: | VERIFIED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P3 - Medium | ||
| Version: | Final | ||
| Target Milestone: | Final | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | Other | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: |
test image
patch to read exif data (again) use libexif to read EXIF orientation for JPEG and TIFF |
||
|
Description
Harald Koenig
2006-02-13 18:05:30 UTC
Can you attach a test-picture for testing purposes? Created attachment 68395 [details]
test image
xzgv --exif-orient img_9152.jpg
doesn't show in portrait mode
Reassigning to the maintainer Ah, thanks. This was introduced by the adjustments necessary to compile with GCC4: I missed to add two typecasts. Without them xzgv does not handle JPEG messages by itself (as it does not recognize them) but hands them over to libImageMagick, which apparently does not know about EXIF. I've submitted the patch but I cannot guarantee whether it was in time for 10.1... it's back again :-(( --exif-orient doesn't work anymore in 11.3! it worked fine in both 11.1 and 11.2! Sorry for the late answer. It's because xzgv-0.9.1 uses glib/gdk to load and view the images, and those routines do not evaluate exif data. This has to be fixed upstream, I'm afraid. As the project is pretty dead, I don't think this is gonna happen, though. Created attachment 408518 [details]
patch to read exif data (again)
code directly from readjpeg.c from xzgv-0.8
(In reply to comment #6) > Sorry for the late answer. It's because xzgv-0.9.1 uses glib/gdk to load and > view the images, and those routines do not evaluate exif data. This has to be > fixed upstream, I'm afraid. As the project is pretty dead, I don't think this > is gonna happen, though. so I have to do it myself :-( voila: the attached patch "works for me" -- I just copied the code from old xzgv-0.8 from file readjpeg.c ... so maybe there is a chance to get xzgv back into factory?! (as I just noticed that factory doesn't ship xzgv anymore:-( please apply the fix for exif-orient and add xzgv to factory and 11.4++ -- pleeeease!!! ;-) Created attachment 425443 [details] use libexif to read EXIF orientation for JPEG and TIFF Okay, okay... I finally got around to make it go again. I have to admit I'm not very fond of reintroducing low level image operations. It is hard to maintain and is a horror to our security guys... A better approach is to use libexif, in my opinion. I haven't fully tested all orientations (just standard landscape and portrait), though. Harald, does this work for you? Test packages are at http://download.opensuse.org/repositories/home:/jreuter:/branches:/home:/jreuter:/Factory/ for now. (In reply to comment #10) > Created an attachment (id=425443) [details] > use libexif to read EXIF orientation for JPEG and TIFF > > Okay, okay... I finally got around to make it go again. I have to admit I'm not > very fond of reintroducing low level image operations. It is hard to maintain > and is a horror to our security guys... A better approach is to use libexif, in > my opinion. I haven't fully tested all orientations (just standard landscape > and portrait), though. agreed, that's a much better solution! > Harald, does this work for you? Test packages are at > http://download.opensuse.org/repositories/home:/jreuter:/branches:/home:/jreuter:/Factory/ > for now. ACK! seems to work fine for me [tm]. here is some statistics about the "tested" images, all showed up with correct orientation: exif * | grep -i orien |sort | uniq -c 122 Orientation |Left-bottom 24 Orientation |Right-top 266 Orientation |Top-left thanks! This is an autogenerated message for OBS integration: This bug (150534) was mentioned in https://build.opensuse.org/request/show/69375 Factory / xzgv Accepted in Factory (as mentioned in previous comment). |