Bug 150559

Summary: ip_resend-0.3-485: printf problems
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Karsten Keil <karsten.keil>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2006-02-13 19:08:37 UTC 
I just tried to compile package ip_resend-0.3-485 with the Intel
C compiler.

It said

1.

ip_resend.c(665): warning #267: the format string requires additional arguments

The source code is

	fprintf(stderr, "ip_resend -o %s: option too long!\n");

Suggest code rework. 

2.

ip_resend_wakeup.c(72): warning #267: the format string requires additional arguments

The source code is

	fprintf(stderr, "ip_resend -o %s: option too long!\n");

I suspect the -Wall compiler flag is not used to compile this
package. There might be some value in adding it in.
Comment 1 Michael Gross 2006-02-14 13:53:21 UTC 
Karsten: This is a security issue, please fix it.
Comment 2 Karsten Keil 2006-02-15 13:03:40 UTC 
I fixed STABLE and update to 0.4 (0.4 mainly includes our enhancments and move from stdout/stderr logs to sys_log). I also fix all other warnings, mostly
char/u_char signess issues.
Should we do updates for old releases ?
Comment 3 Karsten Keil 2006-03-21 23:41:03 UTC 
fixed for next release