Bug 151088

Summary: kdrill-6.4-4: 5 * array subscript out of range
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Mike Fabian <mfabian>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: bugzilla-151088-array-subscript-out-of-range.patch

Description David Binderman 2006-02-15 09:20:57 UTC
I just tried to compile package kdrill-6.4-4 with a non standard version
of the GNU C compiler.

It said

1.

skipsearch.c:350: warning: array subscript out of range

The source code is

        XtAddCallback(SKIPshapeinput[3],XtNcallback, SKIPshapecallback,
                              (XtPointer) 4);

but, earlier in the same file

Widget SKIPshapeinput[3]; /* if SKIP type 4, click on closest shape */

Suggest code rework, possibly array one element bigger.

2.

skipsearch.c:63: warning: array subscript out of range
skipsearch.c:73: warning: array subscript out of range
skipsearch.c:83: warning: array subscript out of range
skipsearch.c:93: warning: array subscript out of range

Duplicates.
Comment 1 Michael Gross 2006-02-15 13:21:02 UTC
Mike: Maby this should get fixed.
Comment 2 Mike Fabian 2006-02-20 17:37:10 UTC
Created attachment 69384 [details]
bugzilla-151088-array-subscript-out-of-range.patch

The patch I used.
Comment 3 Mike Fabian 2006-02-20 17:37:38 UTC
Fixed package submitted to STABLE.

Closing as FIXED.