Bug 151484

Summary: mdbtools-0.5-244: array subscript out of range
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Philipp Thomas <pth>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2006-02-16 13:33:29 UTC 
I just tried to compile package mdbtools-0.5-244 with a non standard version
of the GNU C compiler.

It said

file.c:102: warning: array subscript out of range

The source code is

        gchar basename[33];
        int i;

        for (i=strlen(file_path);i>=0 && file_path[i]!='/';i--);
        if (file_path[i]=='/') {
                strncpy(basename,&file_path[i+1],32);
        } else {
                strncpy(basename,file_path,32);
        }
        basename[33]='\0';

Clearly broken code. Suggest make array one bigger.
Comment 1 Philipp Thomas 2006-02-16 16:29:06 UTC 
Fixed for 10.1 beta4. Thanks for reporting!