Bug 151489

Summary: minicom-2.1-149: 2 * subscript out of range
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Marian Jancar <mjancar>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2006-02-16 13:44:46 UTC
I just tried to compile package minicom-2.1-149 with the Intel C 
compiler.

It said

1.

util.c(298): warning #175: subscript out of range

The source code is

  static char loc_port_list[PARS_VAL_LEN];
  static char *sp = NULL;
  static char *ep;

  /* first pass? */
  if(sp == NULL) {
    strncpy(loc_port_list, port_list, PARS_VAL_LEN);
    loc_port_list[PARS_VAL_LEN] = (char) 0;

Clearly broken code. Suggest make array one bigger.

2.

util.c(310): warning #175: subscript out of range

The source code is

	next_port[PARS_VAL_LEN] = (char) 0;

Clearly broken code. Suggest make array one bigger.
Comment 1 Anna Maresova 2006-02-27 16:58:07 UTC
fixed