Bug 151510

Summary:	Label Linux for SLES9 SP3
Product:	[openSUSE] openSUSE 11.0	Reporter:	Thorsten Kukuk <kukuk>
Component:	YaST2	Assignee:	Jiri Srain <jsrain>
Status:	RESOLVED WONTFIX	QA Contact:	Klaus Kämpf <kkaempf>
Severity:	Normal
Priority:	P2 - High	CC:	aschnell, jplack, jsrain
Version:	Alpha 2
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Thorsten Kukuk 2006-02-16 15:01:16 UTC

In grub menu, there is an entry for SUSE SLES 10 and Fedore Core, but SLES9 SP3
has only "Linux" as Label. YaST2 should detect this correct as SLES9.

Comment 1 Ralf Flaxa 2006-05-03 12:42:02 UTC

I can not confirm this. On my test system I have a SLES 9 SP3 system and
it is correctly detected during update (not the point her) and in the
GRUB menu. Are you sure you did not slightly modify this SP3 so that YaST
may not detect it any more? I don't know what code is used to detect it,
but mine was a vanilla SP3 and it worked fine.

My test was done with a recent snapshot (Beta8 or younger), maybe
your report is just no longer valid?

Comment 2 Thorsten Kukuk 2006-05-03 12:48:30 UTC

The report is valid and reproduceable with every build.
SLES9 SP3 was a fresh installation without modifcations.

Comment 3 Olaf Dabrunz 2006-06-02 16:35:32 UTC

*** Bug 156574 has been marked as a duplicate of this bug. ***

Comment 4 Joachim Plack 2007-10-12 09:12:23 UTC

might be already fixed for the grub case, but all else we need to find a clean
way doing it for all hw platforms.

Idea will be included apropriately into Code11 Bootloader environment structure

Comment 6 Michal Zugec 2007-10-31 09:05:49 UTC

reassign to yast2-bootloader maintainer

Comment 8 Jiri Srain 2008-05-21 07:38:39 UTC

Bootloader module uses just the data it gets from partitioner - Storage::GetForeignPrimary();

Arvin, could you, please, check the code how it detects the name of the system?

Torsten, I know this bug is rather old, however, can you still reproduce it? The logs could help (or at least proof what exactly partitioner returns to bootloader).

Comment 9 Thorsten Kukuk 2008-05-21 15:18:09 UTC

Sorry, I don't have a setup where I can test it and currently no time to create one.

Comment 10 Arvin Schnell 2008-05-21 16:15:16 UTC

GetForeignPrimary() calls GetPrimPartitions() which does only a very
basic detection. For Linux the result is "Linux other" followed by
a number if there are more than one.

Looked at code in SLE10 (since AFAIS this bug war originally
against that version).

Comment 11 Jiri Srain 2008-06-03 12:00:13 UTC

Arvin, thanks, you are right.

Thorsten, just an idea (since I don't have the logs): Which bootloader was your SLES9 instance using? It looks like only code received from GRUB menus are used, thus if you used LILO in SLES9, YaST didn't read it. Can you remember which bootloader was used there?

Comment 12 Thorsten Kukuk 2008-06-13 08:21:46 UTC

It was a plain installation, so grub was used.

Comment 13 Jiri Srain 2008-10-14 08:22:19 UTC

Found the reason: YaST used the label from the SLES9's GRUB menu. However, SLES9 did not use the product name in the GRUB menu, but only plain 'Linux'. That's why the product name cannot be transferred to the 11.0's bootloader menu.

I'm sorry but I cannot do anything about that. Of course detecting the type of the system otherwise could be implemented, but with the lowering number of old installations I don't think it's worth the efforts and risks of possible misbehaviors due to different way of storing the product name on different versions (feel free to disagree).