Bug 151878

Summary: No need to recompute package dependencies after partitioning, etc.
Product: [openSUSE] openSUSE 10.2 Reporter: Andreas Gruenbacher <agruen>
Component: YaST2Assignee: Jiri Srain <jsrain>
Status: RESOLVED FIXED QA Contact: Klaus Kämpf <kkaempf>
Severity: Enhancement    
Priority: P5 - None CC: andreas.hanke, behlert, bugz57, dkukawka, ma, mrmazda, suse-beta
Version: unspecified   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Andreas Gruenbacher 2006-02-17 17:21:28 UTC
In the Installation Settings dialog, computing package dependencies is the slowest part. YaST seems to recompute dependencies whenever it goes back to the dialog, even after changing something unrelated such as switching keyboard layouts or partitioning. I don't see a good reason why this is necessary; can't the resolved dependencies be cached?
Comment 1 Jiri Srain 2006-02-19 23:25:33 UTC
Well, you are right and you are not. Any module can modify the package selection within its dialogs, so it is safe to recompute the dependencies.

Obviously, the correct solution is that each module cares about its dependencies itself.

But there are more problems in the package selection proposal, it calls for complete rewrite, but it is unfortunately too late for 10.1/SLES10.

Keeping it on my list for after 10.1/SLES10, sorry, I'm afraid of fixing it now...
Comment 2 Danny Al-Gaaf 2006-02-20 14:04:05 UTC
How can changes in the partition effect the package selection?
Comment 3 Jiri Srain 2006-02-21 15:21:41 UTC
If you change the partitioning so that the selected packages don't fit into the system, the package selection is reset.
Comment 4 Danny Al-Gaaf 2006-02-21 15:28:09 UTC
IMO this should not happen, it's annoying for the user. 

I would prefer a message/dialog with info that now the partition is to small and if I would reset the package selection. If the user change first the package selection and then change the partitions the automatic reset is really annoying. 
Comment 5 Stefan Behlert 2006-02-22 16:21:55 UTC
comment 3: Yes, that's a valid reason, but can't that be verified by looking at the amount of data that should be stored without re-evaluating?
[And I noticed that it's even done after the keyboard-layout was changed. But that's explained with comment 2, I think. A pity, but I agree, it is better to look at that after 10.1. Danny, I would appreciate if you could create a FATE-entry for that.]
Comment 6 Forgotten User 55iwwMllzz 2006-03-04 22:43:51 UTC
(In reply to comment #1)
> Well, you are right and you are not. Any module can modify the package
> selection within its dialogs, so it is safe to recompute the dependencies.

What impact can a keyboard layout or a time zone change have on package selection?
Comment 7 Lukas Ocilka 2006-03-15 10:44:35 UTC
jsuchome, please comment comment #6 :) [it can, but better to hear it from kbd/timezone maintainer]
Thanks
Comment 8 Jiří Suchomel 2006-03-15 10:51:01 UTC
AFAIK Keyboard and timezone configuration don't have an impact to package selection. I also think they don't trigger new resolving of package dependencies, but I'm not sure how this is done.
Comment 9 Lukas Ocilka 2006-04-21 11:01:20 UTC
Sorry, but let's postpone it to the 10.2
Things like this one cannot be added before :(
Comment 10 Jiri Srain 2006-07-24 09:19:37 UTC
*** Bug 184817 has been marked as a duplicate of this bug. ***
Comment 11 Jiri Srain 2006-08-21 10:34:19 UTC
*** Bug 200542 has been marked as a duplicate of this bug. ***
Comment 12 Jiri Srain 2006-09-26 07:20:27 UTC
Already fixed for 10.2.