Bug 152048

Hi suse,

seems to me that 'ETHTOOL_OPTS' is not used, when set in /etc/sysconfig/network/ifcfg-* scripts. 
- is it a bug ?, because redhat seems to recognise the option...

Using a script like:
-------------------------------------------------
BOOTPROTO='static'
BROADCAST='172.16.50.255'
IPADDR='172.16.50.50'
MTU=''
NAME='NetGear NETGEAR FA120 Adapter'
NETMASK='255.255.255.0'
NETWORK='172.16.50.0'
REMOTE_IPADDR=''
STARTMODE='auto'
UNIQUE='Uc5H.N3lDIGuxQr2'
USERCONTROL='no'
_nm_name='bus-usb-1-4:1.0'
PREFIXLEN=''
ETHTOOL_OPTS='speed 100 duplex half autoneg off'
-------------------------------------------------
the 'ETHTOOL_OPTS' isn't used...
it should run: 
'ethtool -s ethX speed 100 duplex hal...' etc 
upon setting the interface up. It has to done manually from the command-line after starting the network (every time).


It seems like it's missing in /sbin/ifup, so I added these line to it - and it seem to work now. It is a rip from a redhat-fix from dec. 2004, perhaps you're not using the same code-base ?
-------------------------------------------------
...
if [ -n "$MTU" ] ; then
ip link set $INTERFACE mtu $MTU
fi

#### start my mod
#Added by ian.amess@o2.com to set device speed
#This could probably be done a better way but hey it works!!
# snipped from redhat: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=128714
# fixed in: http://rhn.redhat.com/errata/RHBA-2004-511.html
if [ -n "$ETHTOOL_OPTS" ] ; then
ethtool -s $INTERFACE $ETHTOOL_OPTS
echo "Executed: ethtool -s $INTERFACE $ETHTOOL_OPTS"
fi
#### end my mod

ADDRCOUNT=0
for IPVAR in ${!IPADDR*}; do
INDEX=${IPVAR#IPADDR}
if [ -n "$INDEX" ] ; then
eval REMOTE_IPADDR=\$REMOTE_IPADDR$INDEX
eval BROADCAST=\$BROADCAST$INDEX
eval LABEL=\$LABEL$INDEX
eval SCOPE=\$SCOPE$INDEX
eval NETMASK=\$NETMASK$INDEX
eval PREFIXLEN=\$PREFIXLEN$INDEX
eval IP_OPTIONS=\$IP_OPTIONS$INDEX
fi
...
-------------------------------------------------

I'm running suse 9.3, and haven't checked if it's fixed in 10.x (don't have a V10.x)

below is 1) the original ifup-script, 2) my modified ifup-script and 3) my network-config-script (from /etc/sysconfig/network/ifcfg-*)

i know it's a bit messy down below ;-) but attachments don't seem to be an option, so since i actually *did* patch a solution, i'd try and post it anyway... 
(drop me a mail, if it doesn't wrap correctly)

greets
sten

=============================================================
1) ORG ifup-script:
#!/bin/bash
#
# Network interface configuration
#
# Copyright (c) 2002-2003 SuSE Linux AG Nuernberg, Germany.
# All rights reserved.
#

..... SNIPED OUT DUE TO SIZE LIMIT ON DESCRIPTION (65535) ....

case "$BOOTPROTO$SKIP_MAIN_PART" in
	# Skip it
	*skip)
		:
		;;
	# Configure IPv6 6to4 tunnels.
	6to4)

		MESSAGE=`ip link set up dev $INTERFACE $LINK_OPTIONS 2>&1`
		if [ $? != 0 ] ; then
			logerror "failed to set up interface $INTERFACE"
			logerror "$MESSAGE"
			exit $R_ERROR
		fi

		if [ -n "$MTU" ] ; then
			MESSAGE=`ip link set $INTERFACE mtu $MTU 2>&1`
			if [ $? !=0 ] ; then
				logerror "failed to set MTU for interface $INTERFACE"
				logerror "$MESSAGE"
				exit $R_ERROR
			fi
		fi

		MESSAGE=`ip -6 addr add $TUNNEL_LOCAL_IPADDR_V6 dev $INTERFACE 2>&1`
		if [ $? != 0 ] ; then
			logerror "failed to add address $TUNNEL_LOCAL_IPADDR_V6 to" \
			         "interface $INTERFACE"
			logerror "$MESSAGE"
			exit $R_ERROR
		fi

		ifup-route $CONFIG $INTERFACE ${OPTIONS:+-o $OPTIONS}
		retcode=$?
	;;
	*)
		case $SCRIPTNAME in
			ifup)
				retcode=$R_SUCCESS
				if ! ip link set up dev $INTERFACE \
				        ${LLADDR:+address $LLADDR} $LINK_OPTIONS; then
					logerror "Cannot enable interface $INTERFACE."
					retcode=$R_NOTRUNNING
				else
					if [ -n "$MTU" ] ; then
						ip link set $INTERFACE mtu $MTU
					fi
					ADDRCOUNT=0
					for IPVAR in ${!IPADDR*}; do
						INDEX=${IPVAR#IPADDR}
						if [ -n "$INDEX" ] ; then
							eval REMOTE_IPADDR=\$REMOTE_IPADDR$INDEX
							eval BROADCAST=\$BROADCAST$INDEX
							eval LABEL=\$LABEL$INDEX
							eval SCOPE=\$SCOPE$INDEX
							eval NETMASK=\$NETMASK$INDEX
							eval PREFIXLEN=\$PREFIXLEN$INDEX
							eval IP_OPTIONS=\$IP_OPTIONS$INDEX
						fi
						IPADDR=${!IPVAR}
						test -z "$IPADDR" && continue
						if [ -z "$PREFIXLEN" ] ; then
							PREFIXLEN=`mask2pfxlen $NETMASK`
						fi
						case $IPADDR in
							*/*)
								PREFIXLEN=${IPADDR#*/}
								IPADDR=${IPADDR%/*}
								;;
							*) ;;         # IP=$IP${PREFIXLEN:+/$PREFIXLEN} ;;
						esac
						if [ -z "$NETMASK" ] ; then
							NETMASK=`pfxlen2mask $PREFIXLEN`
						fi
						if [ -z "$BROADCAST" ]; then
							BROADCAST=$DEFAULT_BROADCAST
						fi

..... SNIPED OUT DUE TO SIZE LIMIT ON DESCRIPTION (65535) ....

=============================================================
2) my mod ifup-script:
#!/bin/bash
#
# Network interface configuration
#
# Copyright (c) 2002-2003 SuSE Linux AG Nuernberg, Germany.
# All rights reserved.
#

..... SNIPED OUT DUE TO SIZE LIMIT ON DESCRIPTION (65535) ....

case "$BOOTPROTO$SKIP_MAIN_PART" in
	# Skip it
	*skip)
		:
		;;
	# Configure IPv6 6to4 tunnels.
	6to4)

		MESSAGE=`ip link set up dev $INTERFACE $LINK_OPTIONS 2>&1`
		if [ $? != 0 ] ; then
			logerror "failed to set up interface $INTERFACE"
			logerror "$MESSAGE"
			exit $R_ERROR
		fi

		if [ -n "$MTU" ] ; then
			MESSAGE=`ip link set $INTERFACE mtu $MTU 2>&1`
			if [ $? !=0 ] ; then
				logerror "failed to set MTU for interface $INTERFACE"
				logerror "$MESSAGE"
				exit $R_ERROR
			fi
		fi

		MESSAGE=`ip -6 addr add $TUNNEL_LOCAL_IPADDR_V6 dev $INTERFACE 2>&1`
		if [ $? != 0 ] ; then
			logerror "failed to add address $TUNNEL_LOCAL_IPADDR_V6 to" \
			         "interface $INTERFACE"
			logerror "$MESSAGE"
			exit $R_ERROR
		fi

		ifup-route $CONFIG $INTERFACE ${OPTIONS:+-o $OPTIONS}
		retcode=$?
	;;
	*)
		case $SCRIPTNAME in
			ifup)
				retcode=$R_SUCCESS
				if ! ip link set up dev $INTERFACE \
				        ${LLADDR:+address $LLADDR} $LINK_OPTIONS; then
					logerror "Cannot enable interface $INTERFACE."
					retcode=$R_NOTRUNNING
				else
					if [ -n "$MTU" ] ; then
						ip link set $INTERFACE mtu $MTU
					fi
					
					#### start my mod
					#Added by ian.amess@o2.com to set device speed
					#This could probably be done a better way but hey it works!!
					# snipped from redhat: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=128714
					# fixed in: http://rhn.redhat.com/errata/RHBA-2004-511.html
					if [ -n "$ETHTOOL_OPTS" ] ; then
						ethtool -s $INTERFACE $ETHTOOL_OPTS
						echo "Executed: ethtool -s $INTERFACE $ETHTOOL_OPTS"
					fi
					#### end my mod
					
					ADDRCOUNT=0
					for IPVAR in ${!IPADDR*}; do
						INDEX=${IPVAR#IPADDR}
						if [ -n "$INDEX" ] ; then
							eval REMOTE_IPADDR=\$REMOTE_IPADDR$INDEX
							eval BROADCAST=\$BROADCAST$INDEX
							eval LABEL=\$LABEL$INDEX
							eval SCOPE=\$SCOPE$INDEX
							eval NETMASK=\$NETMASK$INDEX
							eval PREFIXLEN=\$PREFIXLEN$INDEX
							eval IP_OPTIONS=\$IP_OPTIONS$INDEX
						fi
						IPADDR=${!IPVAR}
						test -z "$IPADDR" && continue
						if [ -z "$PREFIXLEN" ] ; then
							PREFIXLEN=`mask2pfxlen $NETMASK`
						fi

..... SNIPED OUT DUE TO SIZE LIMIT ON DESCRIPTION (65535) ....


=============================================================
3) my /etc/sysconfig/network/ifcfg-script:
BOOTPROTO='static'
BROADCAST='172.16.50.255'
IPADDR='172.16.50.50'
MTU=''
NAME='NetGear NETGEAR FA120 Adapter'
NETMASK='255.255.255.0'
NETWORK='172.16.50.0'
REMOTE_IPADDR=''
STARTMODE='auto'
UNIQUE='Uc5H.N3lDIGuxQr2'
USERCONTROL='no'
_nm_name='bus-usb-1-4:1.0'
PREFIXLEN=''
ETHTOOL_OPTS='speed 100 duplex half autoneg on'
=============================================================