Bug 152208

Summary: tkimg-1.3-35: four buglets
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Reinhard Max <max>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2006-02-20 11:01:02 UTC
I just tried to compile package tkimg-1.3-35 with the Intel C compiler.

It said

1.

bmp.c(450): warning #175: subscript out of range
bmp.c(451): warning #175: subscript out of range

The source code is

                x += rleBuf[2];
                y += rleBuf[3];

but

        unsigned char rleBuf[2];

Suggest code rework.

2.

ps.c(174): warning #175: subscript out of range

The source code is

    unsigned char buf[41];

	/* ... */

	buf[41] = 0;

Suggest code rework.

3.

tiff.c(564): warning #592: variable "bl" is used before its value is set

The source code is

	unsigned char *pixelPtr = block.pixelPtr;

Suggest initialise local variable "bl" before first use.
Comment 1 Reinhard Max 2006-02-20 17:46:13 UTC
.
Comment 2 Reinhard Max 2006-02-20 17:48:43 UTC
Whoops, closed this one by accident, but will now fix it for 10.1 anyways, so no need to reopen.