Bug 154324

Summary:	Slide show directory handling undefined
Product:	[openSUSE] SUSE Linux 10.1	Reporter:	Klaus Kämpf <kkaempf>
Component:	libzypp	Assignee:	Stefan Hundhammer <shundhammer>
Status:	RESOLVED FIXED	QA Contact:	Klaus Kämpf <kkaempf>
Severity:	Major
Priority:	P5 - None	CC:	aj, dmacvicar, kukuk, ma, suse-beta
Version:	Beta 6
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Klaus Kämpf 2006-03-01 11:11:24 UTC

It looks like slideshow tries to access the wrong mountpoint:

/var/adm/YaST/InstSrcManager/tmp/CurrentMedia/suse/setup/slide/txt/en_US

We probably need some callback to get the current mountpoint of a media.

Comment 1 Stanislav Visnovsky 2006-03-01 14:48:41 UTC

Jiri, IMO SourceProvideDir() should work fine, right?

Comment 2 Stanislav Visnovsky 2006-03-02 12:33:37 UTC

Stefan, this looks like rotten code.

Comment 3 Christian Boltz 2006-03-04 12:16:49 UTC

Is this the reason why there is no slide show when updating (beta3 -> beta6 in my case) or should I open a separate bugreport for this?

You can find the y2logs of the update at https://bugzilla.novell.com/attachment.cgi?id=71245&action=view

Comment 4 Stefan Hundhammer 2006-03-20 16:23:08 UTC

/****************************************************************************************
 * @builtin SourceProvideDir
 * @short make a directory available at the local filesystem
 * @description
 * Let an InstSrc provide some directory (make it available at the local filesystem) and
 * all the files within it (non recursive).
 *
 * @param integer SrcId	Specifies the InstSrc .
 * @param integer medianr Number of the media the file is located on ('1' for the 1st media).
 * @param string dir Directoryname relative to the media root.
 * @return string local path as string
 */
YCPValue
PkgModuleFunctions::SourceProvideDir (const YCPInteger& id, const YCPInteger& mid, const YCPString& d)


The SlideShow.ycp UI has no clue about 2 of the 3 parameters this function expects. This is also the reason why there was a fixed path. 

Yes, this had always been broken by design, but the UI was just as ignorant about all these parameters in the old package manager as for the new libzypp.

Do we need another Pkg:: builtin? Or how should this be handled?
Klaus? Stano? Michael?

Comment 5 Stanislav Visnovsky 2006-03-21 13:02:49 UTC

Slideshow should know from which source it wants to display the slides.
With this information, it should use the media number 1, path should
be fixed.

The problem might be after reboot, because I'm not sure if the slideshow
contents are cached as well.

Comment 6 Stefan Hundhammer 2006-03-21 13:18:49 UTC

No, the slide show has no notion of sources. And simply only always using no. 1 for sure will not bring the desired results.

-> we really need a Pkg:: call that returns that path based on context information about the current source that gets installed.

Comment 8 Stefan Hundhammer 2006-03-21 14:12:03 UTC

It looks like we don't have a concept how to handle the slide show with libzypp.

Comment 10 Stefan Hundhammer 2006-03-28 11:56:51 UTC

Stano just wrote in IRC he managed to fix that, at least for the first stage of the installation. He is working on the second stage, too.