Bug 155647

Summary:	ulogd default column type doesn't match compiled value
Product:	[openSUSE] openSUSE 10.2	Reporter:	Peter Nixon <nix>
Component:	Other	Assignee:	Marius Tomaschewski <mt>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Enhancement
Priority:	P5 - None
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	SuSE Linux 10.0
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Peter Nixon 2006-03-07 00:31:52 UTC

Please add --with-pgsql-log-ip-as-string to the ulogd spec file so that it matches the example Postgresql schema.

Comment 1 Marius Tomaschewski 2006-03-07 19:15:16 UTC

It's too late for 10.1 to switch to ip-as-string, but I can do it for 10.2
(although configure means it is discouraged ;).

I'll not provide any fix it for 10.0, since it is minor and documented, that
you have to comment out the proper lines in the postgress create table file.

Test 10.0 RPMs (_completely_ _untested_) with enabled ip-as-string for all
databases, will appear at http://www.suse.de/~mt/ulogd/

Please let me know if it works for you or not.

Comment 2 Peter Nixon 2006-03-07 20:11:14 UTC

OK. Well, I already have recompiled from src.rpm for my existing 10.0 servers, but I thought that I would submit a bug to make it easier for others also. The only change required is to add --with-pgsql-log-ip-as-string to the configure line in the rpm spec. With this minor change and an rpmbuild -ba ulogd.spec I have fully working ulogd with postgresql and inet field types running in production.

I notice that in SUSE 10.0 there doesn't seem to be much testing of PostgreSQL related modules on a lot of the new packages. (See bug # 149878 which is another of my submissions). Is there anything I can do to help fix this aside from submitting bug reports? We have 50 or so SUSE servers running Postgresql and are a Novell partner.

Comment 3 Marius Tomaschewski 2006-03-08 14:15:27 UTC

I can't add the --with-pgsql-log-ip-as-string option, since it changes
the format and would cause update problems, that have adopted the pgsql
table file.

What I can do it to provide update RPMs containing a fixed table file
with ip address defaults set to INT.

Comment 4 Peter Nixon 2006-03-08 14:22:03 UTC

ok. better than nothing I suppose, although having IP Addresses in INET format is infinitely preferable to integer format. The only reason they have the integer format by default is to keep it compatible with the "other" database backends which don't know how to handle INET correctly and would therefore need to use VARCHAR (thereby causing sorting and speed issues)

Comment 5 Marius Tomaschewski 2006-03-08 14:44:19 UTC

OK, then let's reopen it.

Comment 6 Marius Tomaschewski 2006-05-02 13:44:51 UTC

Andreas,
do you need an update (severity optional?) for this issue on 10.0?

The pgsql table definition needs to be edited and the proper colum
type has to be enabled by the user - by default, a wrong type is
enabled.
Fix is: enable the column type as expected by the binary.

Comment 7 Andreas Jaeger 2006-05-02 14:31:12 UTC

No update for this for 10.0.

Comment 8 Marius Tomaschewski 2006-05-03 11:18:49 UTC

Fixed pgsql.table to use propoer column in 10.1.
Migration to --with-*-log-ip-as-string ==> 10.2.

Comment 9 Marius Tomaschewski 2007-06-01 06:41:46 UTC

Implemented autodetection of the db column types to write
the ip addresses in correct format.

Enabled --with-*-log-ip-as-string & submitted to 10.3.