Bug 156175

Summary: Leading "- " in author in change log entry
Product: [openSUSE] SUSE Linux 10.1 Reporter: Stefan Hundhammer <shundhammer>
Component: libzyppAssignee: Jiri Srain <jsrain>
Status: RESOLVED WONTFIX QA Contact: Klaus Kämpf <kkaempf>
Severity: Minor    
Priority: P5 - None    
Version: Beta 6   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Development Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: screen shot showing the problem

Description Stefan Hundhammer 2006-03-08 17:51:45 UTC 
zypp::ChangeLogEntry::author() always returns a string with a leading "- " for zypp::Package data read from the RPM DB.

I suspect this is the remainder of the line split off after the date of each change log entry as returned by RPM:

% rpm -q --changelog yast2-core | head -n 10
* Mo Sep 12 2005 - kkaempf@suse.de

- ensure string reference does not go out of scope too early
  (#116432)
- V 2.12.27

* Fr Sep 09 2005 - sh@suse.de

- (visnov) Fixed bug #115298: Install on x86_64 horribly slow
  due to excessive memory requirements
Comment 1 Stefan Hundhammer 2006-03-08 17:53:22 UTC 
Check with the "change log" view of yast2-qt-2.13.28 or later.

The problem is probably somewhere in zypp/target/rpm/RpmHeader.cc , but I don't know enough of the parsers there to change anything.
Comment 2 Stefan Hundhammer 2006-03-09 11:05:51 UTC 
Created attachment 71941 [details]
screen shot showing the problem
Comment 3 Stefan Hundhammer 2006-03-09 11:06:28 UTC 
Sample code:

QString YQPkgChangeLogView::changeLogTable( const zypp::Changelog & changeLog ) const
{
    QString html;

    for ( zypp::Changelog::const_iterator it = changeLog.begin();
	  it != changeLog.end();
	  ++it )
    {
	QString changes = htmlEscape( fromUTF8( (*it).text() ) );
	changes.replace( "\n", "<br>" );
	changes.replace( " ", "&nbsp;" );

	html += row(
		    cell( (*it).date()   ) +
		    cell( (*it).author() ) +
		    "<td valign=top>" + changes + "</td>" // cell() calls htmlEscape() !
		    );
    }

    return html.isEmpty() ? "" : table( html );
}
Comment 5 Stefan Hundhammer 2006-04-21 12:41:42 UTC 
It's still there (just checked), but it's not that important. I had a look into that already when I reported it, but I don't know enough about that underlying parser to change it, much less this late in the release phase.

-> LATER
Comment 6 Stephan Kulow 2008-06-25 09:36:23 UTC 
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Comment 7 Stephan Kulow 2008-06-25 09:38:10 UTC 
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Comment 8 Stephan Kulow 2008-06-25 09:42:23 UTC 
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Comment 9 Stephan Kulow 2008-06-25 09:53:49 UTC 
Closing old LATER+REMIND bugs as WONTFIX - if you still plan to work on it, feel free to reopen and set to ASSIGNED.

In case the report saw repeated reopen comments, it's due to bugzilla timing out on the huge request ;(