Bug 156562

Summary: Update overwrites Language settings
Product: [openSUSE] SUSE Linux 10.1 Reporter: Holger Sickenberg <holgi>
Component: Update ProblemsAssignee: Jiri Srain <jsrain>
Status: RESOLVED FIXED QA Contact: Klaus Kämpf <kkaempf>
Severity: Blocker    
Priority: P5 - None CC: suse-beta
Version: Beta 7   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: patch for save_config_finish

Description Holger Sickenberg 2006-03-09 16:12:51 UTC 
Updating from a SUSE Linux 10.0 to 10.1 causes a change in language settings:

10.0: LC_CTYPE=en_US
10.1: LC_CTYPE=en_US.UTF-8

Logs are attached to bug #156519
Comment 1 Christian Boltz 2006-03-10 22:04:34 UTC 
The settings for ROOT_USES_LANG is also changed/reset (to ctype IIRC)
Comment 2 Jiří Suchomel 2006-03-13 11:21:51 UTC 
Jiri, why is save_config_finish.ycp called during update? Shouln't this be done only in installation?
Comment 3 Jiri Srain 2006-03-14 15:17:16 UTC 
There is at least one step which has to be called during update as well. If you want to remove one step from update, either you can move it to separate client, or add appropriate if around it in save_config_finish.
Comment 4 Jiří Suchomel 2006-03-15 08:27:51 UTC 
Yes, I know it can be solved this way.

But my question targeted something different: AFAIK saving language setting wasn't done in update before and now it looks it is. So I'm asking if (and why) something was changed to call save_config_finish.ycp during update.

And if there is just one step (btw which one?) which is needed from save_config_finish  to be called during update, looks like better solution would be to solve this step separately and not the rest of them.
Comment 5 Jiri Srain 2006-03-15 16:14:24 UTC 
At least for 10.0 it worked as it is now.

And you are not right: They were saved always (I just checked the SLES9 code in SVN, folowing ones are always called:

    Mouse::Save();
    Timezone::Save();
    Language::Save();
    Keyboard::Save(true);
    Display::Save();
    ProductFeatures::Save();
Comment 6 Jiří Suchomel 2006-03-15 16:20:49 UTC 
Created attachment 73052 [details]
patch for save_config_finish
Comment 7 Jiří Suchomel 2006-03-15 16:39:51 UTC 
giving to Master of Installation (and raising the severity so it appears on his radar) :-)
Comment 8 Jiri Srain 2006-03-15 16:56:17 UTC 
Done in SVN, will submit with one more bugfix.
Comment 9 Christian Boltz 2006-03-18 14:07:10 UTC 
happened again in beta8 (utf-8 was activated, root language was reset to ctype)

If your patch was just too late for beta8, ignore this - otherwise reopen the bug ;-)