Bug 156966

Summary: pixmp-2.6-1024: wrong return type on function ?
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Ladislav Michnovic <lmichnovic>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2006-03-10 10:10:26 UTC 
I just tried to compile package pixmp-2.6-1024 with the GNU C compiler.

It said

1.

Draw.c:230: warning: "return" with no value, in function returning non-void
Draw.c:235: warning: "return" with no value, in function returning non-void

The source code is

        if (!(--dir->nEntries)) {
                return;
        }

        n = dir - &(SFdirs[SFdirPtr]);
        if ((n < 0) || (n > 2)) {
                return;


I agree with the compiler.  Suggest change return type of function from
"int" to "void".
Comment 1 Ladislav Michnovic 2006-03-13 15:16:32 UTC 
I will fix it. Thank you for reporting.
Comment 2 Ladislav Michnovic 2006-03-13 15:56:08 UTC 
Fixed, submited.