Bug 157024

Summary: NO_PROXY not honored - Bug since SuSE 7.3
Product: [openSUSE] SUSE Linux 10.1 Reporter: Martin Vogt <vogt>
Component: YaST2Assignee: Marius Tomaschewski <mt>
Status: RESOLVED FIXED QA Contact: Klaus Kämpf <kkaempf>
Severity: Normal    
Priority: P5 - None CC: jsrain, suse-beta, vogt
Version: Beta 6   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Martin Vogt 2006-03-10 12:38:26 UTC
Martin Vogt wrote:
> > Martin Vogt wrote:
> >
> >   
>>> >>> Hello SuSE List,
>>> >>>
>>> >>> The module YAST software installation, does not use the "no_proxy" variable?
>>> >>> I have this problem since SuSE 7.3
>>> >>>
>>> >>> regards,
>>> >>>
>>> >>> Martin
>>> >>>   
>>> >>>       
>> >>   
>> >>     
> > The part in the source is:
> > src/media/MediaCurl.cc:
> >
> > SysConfig cfg( "proxy" )
> >
> > if ( cfg.readBoolEntry( "PROXY_ENABLED", false ) ) {
> >       bool useproxy = true;
> >
> >       std::vector<std::string> nope;
> >       stringutil::split( cfg.readEntry( "NO_PROXY" ), nope, ", \t" );
> >       for ( unsigned i = 0; i < nope.size(); ++i ) {
> >         // no proxy: if nope equals host,
> >         // or is a suffix preceeded by a '.'
> >         string::size_type pos = _url.host().find( nope[i] );
> >         if ( pos != string::npos
> >              && ( pos + nope[i].size() == _url.host().size() )
> >              && ( pos == 0 || _url.host()[pos -1] == '.' ) ) {
> >           D__ << "NO_PROXY: " << nope[i] << " matches host " <<_url.host() << endl;
> >           useproxy = false;
> >           break;
> >         }
> >  }
> >
> > the proxy in sysconfig/proxy:
> > NO_PROXY="localhost, my.corp.de, 10.136.16.223"
> >
> > Maybe this needs a tab as seperator ???
> > Although im still not sure if this code segment ist reached at all.
> >   
The code segment is reached.
If I set
PROXY_ENABLED="no"

it works.

So I think its a bug.

Martin
Comment 1 Christian Boltz 2006-03-10 23:23:59 UTC
adjusting summary ;-)
Comment 2 Stanislav Visnovsky 2006-03-16 14:35:54 UTC
Is this still the case with zypp?
Comment 3 Martin Vogt 2006-03-16 14:44:28 UTC
Hm,

google tells me that this is something with i18n.
Do I need to change something in yast?

This was a standard SuSe 10.1b6 installation, done with autoyast2.

Comment 4 Marius Tomaschewski 2006-03-16 15:52:32 UTC
No idea - I've not implemented it. I'll take a look what happens there.
Comment 5 Marius Tomaschewski 2006-03-16 17:33:58 UTC
Fixed in zypp SVN Revision 2502 (not included in Beta8).

Supports exact and subdomain (host foo.bar.de matched by .bar.de).
Networks (e.g. "192.168.0.0/24") in NO_PROXY are not supported
(I don't know if they are allowed in the NO_PROXY variable at all).

Comment 6 Marius Tomaschewski 2006-03-23 14:53:35 UTC
Please retest, if it works on the next avaliable version (RC1). Thanks!
Comment 7 Marius Tomaschewski 2006-04-07 11:45:03 UTC
It works for me now and I consider it fixed. If not, just reopen.