Bug 158409

Summary: control-center-1.4.0.5-83: undefined C code
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Ladislav Michnovic <lmichnovic>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2006-03-15 21:20:45 UTC
I just tried to compile package control-center-1.4.0.5-83 with the
GNU C compiler.

It said

render-background.c:130: warning: operation on "pixels" may be undefined

The source code is

        line[i] = *(pixels++) + *(pixels++) + *(pixels++);

I agree with the compiler. This is undefined C code. Suggest new code

        line[i] = pixels[ 0] + pixels[ 1] + pixels[ 2];
        pixels += 3;
Comment 1 Ladislav Michnovic 2006-04-03 10:34:45 UTC
I'll take a look. Thank you for reporting.
Comment 2 Ladislav Michnovic 2006-04-03 15:13:32 UTC
Fixed, package submited.
Comment 3 JP Rosevear 2006-04-11 01:41:16 UTC
*** Bug 163561 has been marked as a duplicate of this bug. ***