Bug 158757

Summary: festival-1.95-18: undefined C code
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Hendrik Vogelsang <hvogel>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.1   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2006-03-16 18:43:34 UTC
I just tried to compile package festival-1.95-18 with the GNU C compiler.

It said

rateconv.cc:387: warning: operation on "outidx" may be undefined

The source code is

            fir_stereo(inp + inoffset + inbaseidx,
                       coep + cycctr * firlen, firlen,
                       outp + outidx++, outp + outidx++);
 
I agree with the compiler.  Suggest new code

            fir_stereo(inp + inoffset + inbaseidx,
                       coep + cycctr * firlen, firlen,
                       outp + outidx, outp + outidx + 1);
		outidx += 2;
Comment 1 Hendrik Vogelsang 2006-03-21 15:32:54 UTC
submitted.