Bug 165832

Summary:	Yast switch from "update" to "new install" broken
Product:	[openSUSE] SUSE Linux 10.1	Reporter:	Mihnea Istinie <mistinie>
Component:	libzypp	Assignee:	Jiri Srain <jsrain>
Status:	RESOLVED FIXED	QA Contact:	Klaus Kämpf <kkaempf>
Severity:	Blocker
Priority:	P5 - None	CC:	aj, ma, meissner, suse-beta
Version:	RC 1
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	yast2 logs

Description Mihnea Istinie 2006-04-13 11:18:34 UTC

I tried to update a system. The resolver showed several problems, some packages whcih should be updated/deleted/etc. So I decided to go back to the screen where "new installation" is offered for selection.

After selecting "new installation", yast showed an error message in the Packages section, that dependencies cannot be solved. 1 Package selected for installation, total size 350 kB.

After entering the Package selection I got a dependency problem of grub.
All packages (beside wine and a hand full of other) were deselected. The selections were however "enabled"/selected.
 
After talking to Klaus, it looks like Yast does not reset/empty his settings (package dependency calculations, whatever) when switching from the update mode to the new install mode with the back button.

As we offer this possibility to our customers, it should be functional. I agree it's maybe not the usual way to do the job. Unfortunately it was not tested until now.

Comment 1 Mihnea Istinie 2006-04-13 11:19:35 UTC

Created attachment 78212 [details]
yast2 logs

Comment 2 Klaus Kämpf 2006-04-13 11:34:14 UTC

From the description it sounds as if the pool isn't completely resetted (setTransact( false, ResStatus::USER ) for all pool items)

Comment 3 Klaus Kämpf 2006-04-13 11:34:43 UTC

Michael, we might need such a function in ZYpp::

Comment 4 Michael Andres 2006-04-13 13:05:24 UTC

In ZYpp::? 

If this is what pkg-bindings want to do, thay can do it:

=========================================================================
{
  for (zypp::ResPool::const_iterator it = zypp_ptr()->pool().begin()
        ; it != zypp_ptr()->pool().end()
        ; ++it)
    {
      it->status().setTransactValue( zypp::ResStatus::KEEP_STATE, 
                                     zypp::ResStatus::USER) ;
    }
}
=========================================================================

If you like, zypp can provide a common SetTransactValue functor:

struct SetTransactValue
{
  SetTransactValue( ResStatus::TransactValue newVal_r, 
                    ResStatus::TransactByValue causer_r )
  : _newVal( newVal_r )
  , _causer( causer_r )
  {}

  ResStatus::TransactValue   _newVal;
  ResStatus::TransactByValue _causer;

  bool operator()( const PoolItem & pi ) const
  { return pi.status().setTransactValue( _newVal, _causer ); }
};


So the pkg-bindings code could be reduced to

{
  std::for_each( pool.begin(), pool.end(),
                 SetTransactValue( ResStatus::TRANSACT, ResStatus::USER ) );
}

Comment 5 Klaus Kämpf 2006-04-13 13:53:41 UTC

Huh ? KEEP_STATE and TRANSACT ?
The above comment totally confuses me.

Comment #2 was about _resetting_ all transactions

Comment 6 Stanislav Visnovsky 2006-04-13 15:54:12 UTC

In fact, we need to clean up the pool as well to remove target resolvables etc.

This will be tricky.

Comment 7 Mihnea Istinie 2006-04-13 16:09:32 UTC

guys, if the fix is too intrusive/complex/whatever... would it be maybe better to disable the way back ? Once update selected, no way back to "new install" ???

We don't want to introduce now more problems. just my 2 cents

Comment 8 Jiri Srain 2006-04-14 15:25:48 UTC

To disable it is probably the only way to go for box. I talked to Thorsten, it is OK with him also for SLES10 provided adding an add-on product will still be accessible even when user reaches installation proposal.

The problem most probably also occurres if user selects different system for upgrade from the update proposal.

Comment 9 Jiri Srain 2006-04-14 15:31:44 UTC

So, the steps I will do:

- disable going back to installation mode dialog
- disable going back to update partition selection dialog
- remove update partition selection from update proposal

These steps still allow to go back to add-on product dialog provided it was set to install add-on products together with the base product in the installatio mode dialog.

Comment 10 Jiri Srain 2006-04-14 20:28:56 UTC

In addition to above steps, I added add-on products to installation and upgrade proposals (only for SLES and SLED).

Done in SVN, resolving as FIXED.

Comment 11 Jiri Srain 2006-04-18 21:14:42 UTC

*** Bug 158619 has been marked as a duplicate of this bug. ***