Bug 227086

Summary: [opensuse-updater][kde] should clean up during exit
Product: [openSUSE] openSUSE 10.2 Reporter: Michal Svec <msvec>
Component: YaST2Assignee: Thomas Göttlicher <tgoettlicher>
Status: RESOLVED WONTFIX QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None CC: dmacvicar
Version: Final   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on: 340505, 364875    
Bug Blocks: 334498    

Description Michal Svec 2006-12-08 12:47:13 UTC
When you quit opensuseupdater while it's checking current status, the zypp-check-patches (or what's its name) remains running and has to be killed by hand.
Comment 1 Duncan Mac-Vicar 2006-12-11 15:54:54 UTC
zypp-checkpatches continues to run because it is not safe to kill it as it refreshes update sources. If you leave it alone it will finish at some point.

What is missing to detect is that if you start opensuse-updater again it should detect if it running at it id not start the process itself but it was startef by an old applet.

I could also disable exiting until the process is done, but that would not be very safe or not?

Also we could wait to quit until the process is done. That can be slow. But is perhaps the solution I like more.
Comment 2 Michal Svec 2006-12-11 16:19:09 UTC
Actually I'd like to see a solution when everything quits ASAP, that would be for the user the most comfortable approach.

The issue seems to be in zypp-checkpatches not beeing able to quit at all, if I understand it correctly it always has to finish. How about having zypp-checkpatches handle signals and try to quit even before complete finish? I doubt it can't be made interruptible, at least to some extent.

Having at least some interruptibility of zypp-checkpatches, we could visualize the remaining time by having some passive popup stating "opensuseupdater quit, but still waiting until zypp-checkpatches finishes and cleans up".

BTW I hope zypp-checkpatches handles cases when a user kills it as it may and will likely happen. I've done it at least once ;-)
Comment 3 Duncan Mac-Vicar 2006-12-18 15:01:23 UTC
Yes, but those operations are handled in libzypp so the whole library would need to be made interruptible.
Comment 6 Thomas Göttlicher 2007-11-08 15:50:45 UTC
Jano, is there any chance to solve this bug by using bi-directional communication between zypper and opensuseupdater? For example a stop command that the updater could send to tell zypper to exit. 
Comment 7 Jan Kupec 2007-11-09 12:53:49 UTC
Yes, as mentioned in bug 339045, but i don't know the time frame yet.
Comment 8 Michal Svec 2007-11-12 09:44:43 UTC
BTW in 10.3 it feels much better, if I quit the applet the (disk/cpu) activity
seems to stop.
Comment 9 Thomas Göttlicher 2007-11-15 15:52:13 UTC
Later: I will fix that in opensuseupdater as soon as zypper can be told to stop.
Comment 10 Thomas Göttlicher 2008-06-04 08:53:17 UTC
Due to bug 364875 this feature cannot be implemented.