Bug 300515

Summary:	AMD/ATI SB600/700/800 use same SMBus controller devID
Product:	[openSUSE] openSUSE 10.3	Reporter:	Forgotten User FOUTW3E5Ow <forgotten_FOUTW3E5Ow>
Component:	Kernel	Assignee:	Jean Delvare <jdelvare>
Status:	RESOLVED INVALID	QA Contact:	E-mail List <qa-bugs>
Severity:	Major
Priority:	P5 - None	CC:	forgotten_FOUTW3E5Ow, jeffm, joachim.deguara
Version:	Beta 1
Target Milestone:	---
Hardware:	All
OS:	openSUSE 10.3
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:	284195
Bug Blocks:
Attachments:	SB600/SB700/SB800 use same SMBus controll device ID

Description Forgotten User FOUTW3E5Ow 2007-08-15 03:03:40 UTC

We find that SB700 and SB800 use the same SMBus device ID as SB600, which is 0x4385, instead of the already submitted 0x4395.
We submitted an error SB700 SMBus patch in the bugzilla# 284195
Please apply the attached new SMBus patch, which can remove the wrong applied SB700 SMBus patch submitted before.

Besides removing the SB700 wrong patch, the attached patch add SB800 support to kernel, by renaming the PCI_DEVICE_ID_ATI_IXP600_SMBUS into PCI_DEVICE_ID_ATI_SBX00_SMBUS.

Would you please help to apply this new patch ASAP before the release of openSUSE10.3? Because the error device ID 0x4395 will be used in SB800 SATA controller.

I have sent this new patch to kernel.org, I will send you the upstream commit after they apply it.

The patch is generated on the base of linux-2.6.23-rc3, so maybe you need do some small backport to it when you apply it.

Thanks

Comment 1 Forgotten User FOUTW3E5Ow 2007-08-15 03:11:13 UTC

Created attachment 157554 [details]
SB600/SB700/SB800 use same SMBus controll device ID

Besides removing the SB700 wrong patch, the attached patch add SB800 support to kernel as well as SB700.

Comment 2 Greg Kroah-Hartman 2007-08-15 04:51:27 UTC

Should this also be sent to the stable@kernel.org developers also so they can fix the 2.6.22.y releases?

Comment 3 Forgotten User FOUTW3E5Ow 2007-08-15 05:00:27 UTC

I have sent this patch to i2c maintainer Jean Delvare<khali@linux-fr.org>
and i2c@lm-sensors.org before I created this bugzilla item.
I think they will add this patch into the linux kernel source tree after
their review.

Comment 4 Forgotten User FOUTW3E5Ow 2007-08-15 05:04:54 UTC

I think this patch cound NOT appear in 2.6.22.y kernel version,
it may appear in 2.6.23 or later.

Comment 5 Forgotten User FOUTW3E5Ow 2007-08-16 09:39:53 UTC

This patch has been accepted by linux i2c maintainer, and will appear
from linux-2.6.23-rc4 most probably. I will present the git link of
this patch after I get it.

Comment 6 Forgotten User FOUTW3E5Ow 2007-08-16 11:02:27 UTC

I find that the original SB600 patch is NOT in openSUSE10.2 kernel source:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4e6697fcc194db8b45559a9863947c6cbfeea363

I'm not sure whether the original SB600 patch has been applied to
openSUSE10.3 kernel.

There are altogether 3 SB600/SB700 SMBus related patches(in time order):
1. SB600 original patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4e6697fcc194db8b45559a9863947c6cbfeea363

2. SB700 SMBus patch (useless):
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c29c22218b99dad95f7cd0281415a854aeee805c

3. this patch attachment in this bugzilla, which remove SB700 error
patch and add support to SB800 SMBus.

So please apply these three patches one by one.
Thanks

Comment 7 Forgotten User FOUTW3E5Ow 2007-08-21 02:13:57 UTC

My comments above have provided the needed information. thanks.

Comment 8 Jeff Mahoney 2007-08-25 15:40:20 UTC

Jean, this is your playground. Care to comment and/or apply if you consider it safe for 10.3?

Comment 9 Jean Delvare 2007-08-27 07:41:33 UTC

Support for the ATI SB600 SMBus is already included in openSuse 10.3 (it was added upstream in 2.6.21 and openSuse 10.3 is based on 2.6.22.)

The bug (wrong PCI ID listed) which the attached patch fixes, was introduced upstream in 2.6.23-rc1. This means that openSuse 10.3 is not affected, and neither is 2.6.22 upstream, so there's nothing to fix there.

Given that the SB700 and SB800 SMBus use the same PCI ID as the SB600 SMBus (and I thank AMD for this), they are already supported properly in openSuse 10.3. It's just not documented, but I don't think it's a problem. After all, the whole point of reusing the PCI IDs where possible is to avoid backporting patches, isn't it?

So I think that this bug can be closed as invalid with no further action. Jeff, is this OK with you?

Comment 10 Jeff Mahoney 2007-08-27 13:56:42 UTC

Thanks Jean, that works for me.

Shane, we've seen a number of reports from you recently that either add hardware support to an already shipped release or fix problems which don't exist in our kernel simply because the problems were introduced in a version after 2.6.22 or fixed before 2.6.22. I appreciate the effort in keeping us updated, but the former is a violation of our patch acceptance policy, and the latter could be avoided by checking the X-Git-Tag header for the version in the raw version of the git patch to ensure it's a patch that is needed for our kernel. Either way, unnecessary effort could be avoided with a little due diligence.

Closing as INVALID.

Comment 11 Forgotten User FOUTW3E5Ow 2007-08-28 01:10:38 UTC

Hi Jeff, sorry for the unnecessary work to you.

Usually when we create a kernel patch, we will submit it to kernel.org
and many linux distributions to be released very soon through bugzillas.
We will check it more carefully in the future to see whether the bugzilla
is really valid to this distribution. Thanks.

Shane