Bug 378595

Summary: Xen network-bridge script does not work
Product: [openSUSE] openSUSE 11.0 Reporter: James Fehlig <jfehlig>
Component: XenAssignee: James Fehlig <jfehlig>
Status: VERIFIED FIXED QA Contact: Jason Douglas <jdouglas>
Severity: Critical    
Priority: P5 - None CC: coolo, kukuk, mt, radmanic
Version: Alpha 3plusFlags: coolo: SHIP_STOPPER-
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Development Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: network-bridge patch that removes bridge-related operations handled by ifdown

Description James Fehlig 2008-04-09 22:46:40 UTC
With changes to sysconfig and networking scripts, the Xen network-bridge script no longer works.


xen67:~ # brctl addbr tmpbr
xen67:~ # ip addr add 151.155.144.67/22 dev tmpbr label tmpbr
xen67:~ # ifdown eth0
    eth0      device: Intel Corporation 80003ES2LAN Gigabit Ethernet Controller (Copper) (rev 01)
xen67:~ # ip link set eth0 name peth0
xen67:~ # ip link set tmpbr name eth0
xen67:~ # ip link set peth0 up
xen67:~ # brctl addif eth0 peth0
xen67:~ # brctl show
bridge name     bridge id               STP enabled     interfaces
eth0            8000.003048347d8a       no              peth0
xen67:~ # ifup eth0
    eth0
    eth0      Warning: Bridge eth0 already up!
xen67:~ # ifstatus eth0
    eth0
    eth0      is down
xen67:~ # ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 16436 qdisc noqueue
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: peth0: <BROADCAST,MULTICAST,PROMISC,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast qlen 1000
    link/ether 00:30:48:34:7d:8a brd ff:ff:ff:ff:ff:ff
    inet6 fe80::230:48ff:fe34:7d8a/64 scope link
       valid_lft forever preferred_lft forever
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop qlen 1000
    link/ether 00:30:48:34:7d:8b brd ff:ff:ff:ff:ff:ff
11: eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop
    link/ether 00:30:48:34:7d:8a brd ff:ff:ff:ff:ff:ff
    inet 151.155.144.67/22 scope global eth0
xen67:~ # ip r
127.0.0.0/8 dev lo  scope link
xen67:~ # ip link set eth0 up
xen67:~ # ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 16436 qdisc noqueue
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: peth0: <BROADCAST,MULTICAST,PROMISC,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast qlen 1000
    link/ether 00:30:48:34:7d:8a brd ff:ff:ff:ff:ff:ff
    inet6 fe80::230:48ff:fe34:7d8a/64 scope link
       valid_lft forever preferred_lft forever
3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop qlen 1000
    link/ether 00:30:48:34:7d:8b brd ff:ff:ff:ff:ff:ff
11: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue
    link/ether 00:30:48:34:7d:8a brd ff:ff:ff:ff:ff:ff
    inet 151.155.144.67/22 scope global eth0
    inet6 fe80::230:48ff:fe34:7d8a/64 scope link
       valid_lft forever preferred_lft forever
xen67:~ # ip r
151.155.144.0/22 dev eth0  proto kernel  scope link  src 151.155.144.67
127.0.0.0/8 dev lo  scope link

So it can be made to work (with static configuration) but default route is not configured.  I have not tried on a dhcp configured interface.
Comment 1 James Fehlig 2008-04-10 23:37:41 UTC
I have disabled use of ifup/ifdown in network-bridge script for the time being.  This allows the script to work (at least on configurations I have tried) until we have time to resolve issues in sysconfig.
Comment 22 Marius Tomaschewski 2008-05-22 06:32:10 UTC
Stephan, can we go the way as in above comments for 11.0?

That is, submit ifup-bridge script fix to sysconfig + xen
network-bridge modifications to xen?
Comment 26 Stephan Kulow 2008-05-22 13:09:48 UTC
I only veto a change after next monday. If it's ready by now, I leave it up to Jim to say go or no-go.
Comment 27 James Fehlig 2008-05-22 17:28:03 UTC
(In reply to comment #26 from Stephan Kulow)
> I only veto a change after next monday. If it's ready by now, I leave it up to
> Jim to say go or no-go.

I've done some more testing today with the ifup-bridge script in comment #13 and a patched network-bridge.  All looks good.  I've tested with dhcp configured device, static configured device, device with vlan configured on it, and setting up bridges on multiple devices.  All seems fine.

IMO, for RC1 we should go with ifup-bridge in comment #13 *and* my patch to network-bridge - which I'll attach for reference.  I'll plan to include the network-bridge patch in our Xen submission for RC1 tomorrow (Friday).

Marius, can you submit the ifup-bridge in time for RC1?

BTW, I won't be in the office on Monday 5/26 (US holiday) or Tuesday 5/27 and won't have network access - so hope all of this goes well.

Comment 28 James Fehlig 2008-05-22 17:31:52 UTC
Created attachment 217595 [details]
network-bridge patch that removes bridge-related operations handled by ifdown
Comment 29 Marius Tomaschewski 2008-05-23 10:39:05 UTC
(In reply to comment #27 from Jim Fehlig)
> Marius, can you submit the ifup-bridge in time for RC1?

Submitted to /work/src/done/STABLE/sysconfig.
Comment 30 James Fehlig 2008-05-23 21:53:20 UTC
I did more testing with new sysconfig and xen-tools rpms and all looks good.  New Xen package submitted to /work/src/done/STABLE/xen.