|
Bugzilla – Full Text Bug Listing |
| Summary: | Help button in GTK installation is not translated. | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.0 | Reporter: | Ladislav Michnovic <lmichnovic> |
| Component: | YaST2 | Assignee: | Michael Meeks <mmeeks> |
| Status: | RESOLVED FIXED | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Minor | ||
| Priority: | P5 - None | CC: | forgotten_h13THG8RK1, ke |
| Version: | RC 1 | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: | screenshot | ||
It's annoying, but by no mean "major" ;) "Help" is translated more than once, thus it is either a yast (or a gtk) bug. Both GTK and yast should use LANG I guess... The language selection already happened in the 1st stage. Anyway, it might be a good idea to use yast gettext stuff to translate this instead of relying on GTK. Too late now though -- the translations is likely frozen, so we'd just have the original string in English being used... So, LATER... added the translation markup in HEAD, which will be ineffective until the translators do their stuff - but harmless enough: I found another few broken strings too. Michael: you didn't really fix the button. It's still implemented as:
wizard->m_help_button = gtk_button_new_from_stock (GTK_STOCK_HELP);
So, it will use some GTK string that apparently isn't being translated.
We need to move the following into some getHelpText() and getHelpImage():
dialog->title_image = gtk_image_new_from_stock (GTK_STOCK_HELP,
GTK_ICON_SIZE_LARGE_TOOLBAR);
dialog->title_label = gtk_label_new (_("Help"));
Anyway, I am not sure it's a good idea to make changes at this point because this new strings won't be translated. We'll end up with the Help button always un-translated. At least now, it should be translated when the desktop is installed, and LANG or whatever is set properly.
By the way, I'm not sure we should make "YaST" translatable. That's the program's name like "GEdit" or "Mozilla Firefox" is used untranslated... I would personally vote to get rid of "%s - YaST" from the window title altogether.
I dared to backport this to the 11.0 branch. If they are marked or not does not matter and if they are marked, they get the Help translation in case it happens to be in another pot file. thanks Stephan :-) and Ricardo - you're right I guess; but OTOH translators don't have to translate the string ;-) Wrt. 'stock' items not being properly translated: that is odd indeed: sounds like some gtk+ translations are missing from somewhere. Perhaps if switching the UI language during install doesn't include new gtk+ translations we need to do these manually as you suggest. |
Created attachment 219143 [details] screenshot In the second stage of the installation, when GNOME was selected and YaST uses gtk, the Help button is in English. See attached screenshot.