Bug 428532

Summary: ToolStripMenuItem: Begin implementation
Product: [Mono] UI Automation Reporter: Brad Taylor <btaylor1>
Component: Winforms - ATKAssignee: Andres Aragoneses <aaragoneses>
Status: RESOLVED FIXED QA Contact: E-mail List <mono-a11y-bugs>
Severity: Enhancement    
Priority: P4 - Low    
Version: Unspecified   
Target Milestone: Release 0.9   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 428604, 428534    

Description Brad Taylor 2008-09-22 18:08:32 UTC 
Implement AtkAccessible and AtkComponent for MenuItem (deprecated; new: ToolStripMenuItem) and develop initial unit test.

Specification
==============

Acts As: Menu Item
Similar To: GtkMenuItem
Provides: AtkAccessible, AtkComponent, AtkAction, AtkText, AtkSelection
Default State: Enabled, Selectable, Sensitive, Showing, Visible
Comment 1 Andres Aragoneses 2008-09-22 18:27:31 UTC 
The implementation of a case of deprecation may be pretty fast due to the use of the same provider.
Comment 2 Andres Aragoneses 2008-09-24 20:44:37 UTC 
New default assignee and QA (although we'll create a new dummy mailing list specifically for QA soon).
Comment 3 Brad Taylor 2008-09-25 22:11:48 UTC 
Moving all of these to P4 to show that they have been triaged.  Will be reprioritizing these properly tomorrow.
Comment 4 Andres Aragoneses 2008-10-14 20:43:00 UTC 
I should have assigned this to myself earlier.
Comment 5 Andres Aragoneses 2008-10-23 03:31:18 UTC 
Firs implementation + children testing committed on r116810. However, not closing yet because of an NRE in the tests (generated in the provider).
Comment 6 Andres Aragoneses 2008-10-23 21:03:42 UTC 
The NRE was fixed this morning by mario (r116854). Thanks!

After that, I had another failing test and started to debug it, to find out that ProviderFactory.GetProvider had a bug. Sandy fixed it (r116865).

What I think is missing now about this is proper Navigation in the MenuItem provider, since this code is returning always false (has no children):

http://monoport.com/37880

Or maybe the provider didn't hook on this bridge-test call:

parentMenu.DropDownItems.AddRange (subMenus);

(Adding menuitems to a menuitem.)
Comment 7 Andres Aragoneses 2008-10-24 23:21:56 UTC 
Sandy told me today it should be fixed, although no tests finished yet.
Comment 8 Andres Aragoneses 2008-10-28 15:42:56 UTC 
I hate to put a lot of hours in a bug that had such a low estimation rate, but I'm getting a lot of trouble dealing with small defects in the provider side.

So, as a progress summary of this:
- Mario fixed the children discovery on r117211.
- I fixed the class hierarchy in preparation of addition/removal of children at runtime (r117270,r117271,r117272).

Now I'm debugging an issue with the StateType.Enabled not being added to the states of the menu.
Comment 9 Andres Aragoneses 2008-10-28 18:54:20 UTC 
(In reply to comment #8 from Andrés G. Aragoneses)
> Now I'm debugging an issue with the StateType.Enabled not being added to the
> states of the menu.

Stupid problem. Fixed all in r117288.