|
Bugzilla – Full Text Bug Listing |
| Summary: | ColorDialog: Begin implementation | ||
|---|---|---|---|
| Product: | [Mono] UI Automation | Reporter: | Brad Taylor <btaylor1> |
| Component: | Winforms - UIA | Assignee: | E-mail List <mono-a11y-bugs> |
| Status: | CONFIRMED --- | QA Contact: | E-mail List <mono-a11y-qa> |
| Severity: | Enhancement | ||
| Priority: | P4 - Low | ||
| Version: | Unspecified | ||
| Target Milestone: | Release 1.1 | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Bug Depends on: | |||
| Bug Blocks: | 428474 | ||
| Attachments: |
Patch Uploaded.
Patch Uploaded. Fixed Invoke action. unit test |
||
|
Description
Brad Taylor
2008-09-22 21:54:13 UTC
Mass change of QA contact. Sorry for bugspam. Update your watch-lists. Moving all of these to P4 to show that they have been triaged. Will be reprioritizing these properly tomorrow. Created attachment 262582 [details]
Patch Uploaded.
BaseColorControl still has SmallColorControl, which is color square.
Created attachment 263105 [details]
Patch Uploaded.
(In reply to comment #4 from Neville Gao) > Created an attachment (id=263105) [details] > Patch Uploaded. OK to commit. Committed in r122613. Created attachment 263526 [details]
Fixed Invoke action.
(In reply to comment #7 from Neville Gao) > Created an attachment (id=263526) [details] > Fixed Invoke action. OK to commit Committed in r122661. Missing unit test. How do we get BaseColorControl using Navigate, we couldn't get the exact one using Navigate. Not sure, did you try showing your color dialog and then looping BaseTest.bridge.StructureChangedEvents until getting the WindowProvider with Parent != null? I was trying to get ColorDialog using GetProviderFromControl(), and then loop it's children. If the child has children, it must be BaseColorControl. But GetProviderFromControl() can't accept a component-type argument. Is there a way to test dialog based control? Yes, our tests need love (generics maybe?) In the meantime use GetProvider to return ProviderFactory.GetProvider, that should work. Neville: what's the status on this? Created attachment 272206 [details]
unit test
Now, we can get BaseColorControl using ShowDialog() in another thread, but have a problem getting internal property with Helper, as Test class is not "friends" of Providers class. Mario, could you review? Thanks. (In reply to comment #15) > Created an attachment (id=272206) [details] > unit test The patch looks OK. (In reply to comment #16) > Now, we can get BaseColorControl using ShowDialog() in another thread, but have > a problem getting internal property with Helper, as Test class is not "friends" > of Providers class. Right, UIAutomationWinforms is friend of MWF, and UIAutomationWinformsTest is friend of UIAutomationWinforms, but friendship is not transitive nor reciprocal. However, did you try navigating your BaseColorControl and searching for your Helper provider? that should work. Committed in r126801. (In reply to comment #18) > However, did you try navigating your BaseColorControl and searching for your > Helper provider? that should work. Oh, seems BaseColorControl only navigates to SmallColorControls. Moving enhancement requests (e.g.: new features pending completion) to the 1.1 milestone. |