Bug 430398

Summary:	Keyboard navigation in the GTKFileChooser
Product:	[openSUSE] openSUSE 11.0	Reporter:	Clinton Gormley <clint>
Component:	GNOME	Assignee:	Federico Mena Quintero <federico>
Status:	RESOLVED UPSTREAM	QA Contact:	E-mail List <qa-bugs>
Severity:	Minor
Priority:	P3 - Medium	CC:	vuntz
Version:	Final	Keywords:	should_go_upstream
Target Milestone:	---
Hardware:	All
OS:	openSUSE 11.0
URL:	See comments for multiple URLs
Whiteboard:	gnome-usability
Found By:	Customer	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	338003

Description Clinton Gormley 2008-09-27 11:26:12 UTC

There are a number of issues with keyboard navigation in the GTKFileChooser, which result in me having to resort to using the mouse, which is annoying to say the least:

1) Quick-find
-------------
By this I mean the box that appears at the bottom right of the current block when you start typing.

Control characters are never going to be a valid input for the quick find box, so if I start typing a filename then press (eg) Alt-P to go to the Places block, it should realise that I no longer want to be in the quick find box

2) Places
---------
Once you're in the Places block, there is no way to go immediately back to the file list.  Enter or Tab should return focus to the file list

3) Location
------------------
I start typing my Location of choice, it auto-completes, then I press Enter - it should return focus to the file list - I've already used the Location field to make  a big change in my current path. Enter signals that I'm done, and want to return to the normal flow of using the file list.

4) Search
---------
I think this has been fixed, as I can't replicate it now, but it used to be that when I pressed Alt-P to go to places, then the Search box would get focus, and I'd need to click out of it

many thanks

clint

Comment 1 Vincent Untz 2008-09-29 13:54:19 UTC

Federico: should we upstream this? I'm not sure what's the status here.

(2 is WONTFIX: use alt+tab)

Comment 2 Clinton Gormley 2008-09-29 14:00:33 UTC

> (2 is WONTFIX: use alt+tab)

Ah excellent.  But WONTFIX? As somebody who has used linux for 12 years, and suse for 8 of those, I didn't know about Alt-TAB.

It should at least be made more obious

Comment 3 Clinton Gormley 2008-09-29 14:03:37 UTC

(In reply to comment #2 from Clinton Gormley)
> > (2 is WONTFIX: use alt+tab)
> 
> Ah excellent.  But WONTFIX? As somebody who has used linux for 12 years, and
> suse for 8 of those, I didn't know about Alt-TAB.
> 
> It should at least be made more obious

I should at least have tried it before posting - Alt-TAB switches windows, it doesn't move focus from the Places box back to the file list.

To be clear, what I'm wanting to do (and could do in 10.3) was :

 - Ctrl-O   : open the file chooser
 - Alt-P    : jump to Places
 - Down     : move to the shortcut I want
 - TAB      : back to the file list
 - $keys    : quick find the file I want

Comment 4 Vincent Untz 2008-09-29 14:15:39 UTC

Sorry, I meant shift+tab :-)

Comment 5 Clinton Gormley 2008-09-29 14:28:32 UTC

(In reply to comment #4 from Vincent Untz)
> Sorry, I meant shift+tab :-)
> 

Yeah - that doesn't work either :)

Shift-Tab takes me back to the "path element" buttons above the file list, not to the file list itself.

Also, if I've used quick find to select my current place, then the first shift-tab keypress just cancels the quick find, it doesn't "do what I meant to do as though I weren't in quick find", which is the same problem as in [1]

Comment 6 Vincent Untz 2008-09-29 14:36:03 UTC

Heh, okay, I misread your comment. Sorry :-)

Comment 7 Federico Mena Quintero 2008-09-30 18:16:45 UTC

Yes, this should go upstream.  Those are nice suggestions, Clinton; I'll try to get them implemented.

[Hmmm, did hitting Tab to switch from Places to the file list ever work?  The "add/remove" buttons were always in the way, I think...]

Comment 8 Federico Mena Quintero 2008-09-30 18:44:46 UTC

I filed these:

(1) http://bugzilla.gnome.org/show_bug.cgi?id=554476 - Mnemonics during interactive search

(2) http://bugzilla.gnome.org/show_bug.cgi?id=554477 - Enter while in Places bar should take you to the file list

See also http://bugzilla.gnome.org/show_bug.cgi?id=161489 about making the left/right arrow keys switch between the Places bar and the file list.

(3) Enter during interactive search means "I found what I was looking for; use it and dismiss the file chooser dialog".  If you want just to dismiss the little interactive window, press Esc.

(4) http://bugzilla.gnome.org/show_bug.cgi?id=554480 - Oooh, nice catch.  This happens if you start in a folder which is *not* bookmarked.  If you then hit Alt-P, then the first item in the Places bar gets selected (i.e. "Search"), and the text entry gets the focus.

Comment 9 Clinton Gormley 2008-09-30 18:52:28 UTC

> (3) Enter during interactive search means "I found what I was looking for; use
> it and dismiss the file chooser dialog".  If you want just to dismiss the
> little interactive window, press Esc.

Yes, but... 

We KNOW that any control key that isn't an up or down arrow isn't valid input for the interactive search, so instead of forcing the user to press ESC, wouldn't it be better exit interactive search automatically and pass that control key back to the container?

Comment 10 Clinton Gormley 2008-09-30 18:53:16 UTC

(In reply to comment #9 from Clinton Gormley)

> We KNOW that any control key that isn't an up or down arrow isn't valid input
> for the interactive search, so instead of forcing the user to press ESC,
> wouldn't it be better exit interactive search automatically and pass that
> control key back to the container?
> 

Damn - I need to learn to read before posting :)

sorry

Comment 11 Vincent Untz 2010-11-27 10:35:46 UTC

As bugs were filed upstream, closing as UPSTREAM.