Bug 447851

I've committed a patch (UIAutomationWinforms-trunk r121259) to fix the tests  to pass, however some of them are not passing. Notice that you will need to apply the patches in Bug #435988 and Bug #455950 to get the following output:

Tests run: 524, Failures: 5, Not run: 176, Time: 119.525 seconds

Test Case Failures:
1) MonoTests.Mono.UIAutomation.Winforms.RadioButtonProviderTest.ElementSelectedEventTest : Not implemented
at MonoTests.Mono.UIAutomation.Winforms.RadioButtonProviderTest.ElementSelectedEventTest () [0x00000] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/AssemblyInfo.cs:1
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00057] in /home/mario/repository/mcarrion/mcs/class/corlib/System.Reflection/MonoMethod.cs:159

2) MonoTests.Mono.UIAutomation.Winforms.StatusStripProviderTest.NavigationTest :   We shouldn't have a child
  Expected: null
  But was:  <Mono.UIAutomation.Winforms.ToolStripLabelProvider>

at MonoTests.Mono.UIAutomation.Winforms.StatusStripProviderTest.NavigationTest () [0x000ea] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/StatusStripProviderTest.cs:220
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00057] in /home/mario/repository/mcarrion/mcs/class/corlib/System.Reflection/MonoMethod.cs:159

3) MonoTests.Mono.UIAutomation.Winforms.TextRangeProviderTest.FindAttribute : System.NullReferenceException : Object reference not set to an instance of an object
at MonoTests.Mono.UIAutomation.Winforms.TextRangeProviderTest.FindAttribute () [0x00044] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/TextRangeProviderTest.cs:1048
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00057] in /home/mario/repository/mcarrion/mcs/class/corlib/System.Reflection/MonoMethod.cs:159

4) MonoTests.Mono.UIAutomation.Winforms.TextRangeProviderTest.GetAttributeValue :   Expected string length 5 but was 10. Strings differ at index 1.
  Expected: "Arial"
  But was:  "Albany AMT"
  ------------^

at MonoTests.Mono.UIAutomation.Winforms.TextRangeProviderTest.GetAttributeValue () [0x0007e] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/TextRangeProviderTest.cs:1034
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00057] in /home/mario/repository/mcarrion/mcs/class/corlib/System.Reflection/MonoMethod.cs:159

5) MonoTests.Mono.UIAutomation.Winforms.TextRangeProviderTest.RichTextBoxFindAttribute : System.NullReferenceException : Object reference not set to an instance of an object
at MonoTests.Mono.UIAutomation.Winforms.TextRangeProviderTest.RichTextBoxFindAttribute () [0x000b7] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/TextRangeProviderTest.cs:1076
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00057] in /home/mario/repository/mcarrion/mcs/class/corlib/System.Reflection/MonoMethod.cs:159

Hours updated. 1 test is failing. 

Need to write "children added before parent test"

Test are passing, however I can't close this until all dependencies are marked as FIXED. r121545

I'm removing the dependency on bug #446783, since the test has been modified to pass without any dependency on a fix for that bug.

As for the other dependencies...are the tests passing without having those patches applied?

I don't get any failures when patches applied. Removing the patches I get:

Test Case Failures:
1) MonoTests.Mono.UIAutomation.Winforms.ToolBarProviderTest.NavigationTest :   We must have a child
  Expected: not null
  But was:  null

at MonoTests.Mono.UIAutomation.Winforms.ToolBarProviderTest.NavigationTest () [0x00063] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/ToolBarProviderTest.cs:84
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00057] in /home/mario/repository/mcarrion/mcs/class/corlib/System.Reflection/MonoMethod.cs:159

2) MonoTests.Mono.UIAutomation.Winforms.ToolBarProviderTest.ToolBarButtonBasicPropertiesTest : System.NullReferenceException : Object reference not set to an instance of an object
at MonoTests.Mono.UIAutomation.Winforms.TestHelper.TestAutomationProperty (IRawElementProviderSimple provider, System.Windows.Automation.AutomationProperty property, System.Object expectedValue) [0x00000] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/TestHelper.cs:95
at MonoTests.Mono.UIAutomation.Winforms.BaseProviderTest.TestProperty (IRawElementProviderSimple provider, System.Windows.Automation.AutomationProperty property, System.Object expectedValue) [0x00000] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/BaseProviderTest.cs:329
at MonoTests.Mono.UIAutomation.Winforms.ToolBarProviderTest.ToolBarButtonBasicPropertiesTest () [0x0002c] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/ToolBarProviderTest.cs:118
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00057] in /home/mario/repository/mcarrion/mcs/class/corlib/System.Reflection/MonoMethod.cs:159

3) MonoTests.Mono.UIAutomation.Winforms.ToolBarProviderTest.ToolBarButtonProviderPatternTest : System.NullReferenceException : Object reference not set to an instance of an object
at MonoTests.Mono.UIAutomation.Winforms.ToolBarProviderTest.ToolBarButtonProviderPatternTest () [0x0002c] in /home/mario/repository/mcarrion/uia2atk/UIAutomationWinforms/UIAutomationWinformsTests/ToolBarProviderTest.cs:144
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00057] in /home/mario/repository/mcarrion/mcs/class/corlib/System.Reflection/MonoMethod.cs:159

The patch in bug #455950 is a dependency, and the patch in Bug #435988 is not tested, so we need to add a new test.

Hey Neville we are getting failures when running your tests: PrintPreviewControlProvider and SplitContainerProvider, seems that you removed some patterns and you didn't update your tests. 

Can you update them?

Created attachment 263104 [details]
Tested SplitContainer.

PrintPreviewControl needs to load a doc to support IScrollProvider, will we need to upload one to UIAutomationWinformsTest dir?

Splitter also needs to update.

(In reply to comment #7 from Neville Gao)
> Created an attachment (id=263104) [details]
> Tested SplitContainer.
OK to commit.

Committed in r122524.

Created attachment 263332 [details]
Tested Splitter.

(In reply to comment #10 from Neville Gao)
> Created an attachment (id=263332) [details]
> Tested Splitter.
OK to commit.

Committed in r122620.

Created attachment 266959 [details]
Tests output.

Tests run: 2633, Failures: 11, Not run: 98, Time: 285.426 seconds

Neville:
Can you update your tests (PrintPreviewControlroviderTest and PrintPreviewControlroviderTest) to close this bug?

There is another issue. Unit test should be run on a platform that installs printers, or an error messagebox says: No Pinrters Installed, and the test will not pass.

Created attachment 267281 [details]
Printers example

Neville:

This example will work for your test. If you are missing CUPS the following message will print:

"libcups not found. To have printing support, you need cups installed"

so, you will need to install cups-devel (and maybe libgnomecups-devel?) and rebuild libgdiplus.

I guess using "System.Drawing.Printing.PrinterSettings.InstalledPrinters.Count > 0" will be better.

With my recent change: 
http://lists.ximian.com/pipermail/mono-patches/2009-January/139603.html

I get the following output:
Tests run: 2636, Failures: 20, Not run: 97, Time: 778.402 seconds
http://paste2.org/p/137460

Basically the new failing tests are:

- HelpProviderTest.FragmentRootAsParentTest
- ToolStripButtonProviderTest.FragmentRootAsParentTest
- ToolStripDropDownButtonProviderTest.FragmentRootAsParentTest
- ToolStripDropDownButtonProviderTest.IsKeyboardFocusablePropertyTestForChildren
- ToolStripLabelProviderTest.FragmentRootAsParentTest
- ToolStripMenuItemProviderTest.FragmentRootAsParentTest
- ToolStripSeparatorProviderTest.FragmentRootAsParentTest 
- ToolStripSeparatorProviderTest.IsContentElementPropertyTest
- ToolStripSplitButtonProviderTest.FragmentRootAsParentTest

Hello people, 

I'm happy to announce we have 0 failing tests:

http://paste2.org/p/137727

However, there are some [Ignore]d tests and I've disabled PrintPreviewControlroviderTest, in the meantime all our tests are passing. Congratulations!

Mario, since you've hit 0, do you want to close this bug?  I figure the PrintPreviewControlProviderTest issue will be fixed in the PrintPreview enhancement that already exists.

Sure.

Closing!.