Bug 471765

Created attachment 269445 [details]
Fix gtk dialogue button order.

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-GB; rv:1.9.0.3) Gecko/2008091700 SUSE/3.0.3-1.1 Firefox/3.0.3

GTK dialogues have the buttons ordered the opposite way round to the rest of the world, meaning people used to using other desktop environments or windows click the [Discard Changes] button instead of the [Save] button that is normally in the same place, leading to lots of frustration and lost work.

There is a setting that can be put in the gtkrc to switch the button order to be the same as the rest of the world ( http://developer.gimp.org/api/2.0/gtk/GtkDialog.html#gtk-dialog-set-alternative-button-order ). Unfortunately this hardly works for any applications as it seems it requires the application developer to call gtk_dialog_set_alternative_button_order manually to apply any settings, which few do.

There is a workaround which is simply to call gtk_dialog_set_alternative_button_order every time a dialogue is created or a button is added to a dialogue. That way the application dialogues follow the user preferences regardless of what the application developer does.

Here's a patch http://bw.uwcs.co.uk/b/fixgtk.diff

and a screenshot of it in action

http://bw.uwcs.co.uk/b/gtk_vanquished.png


Reproducible: Always

Steps to Reproduce:
0. Add gtk-alternative-button-order=1 to gtkrc
1. Open a GTK application such as gedit
2. Modify a document
3. Click close
4. Note the "lose my work" button is still where the rest of the world has save.
Actual Results:  
Dialogues do not follow button order setting.

Expected Results:  
Dialogues do follow button order setting.