Bug 475082

Summary:	OpenFileDialog: PopupButton has wrong states -- Everything fixed except +/- "focused" state.
Product:	[Mono] UI Automation	Reporter:	calen chen <cachen>
Component:	Winforms - General	Assignee:	E-mail List <mono-a11y-bugs>
Status:	NEW ---	QA Contact:	E-mail List <mono-a11y-qa>
Severity:	Normal
Priority:	P2 - High
Version:	Release 1.0
Target Milestone:	Release 1.1
Hardware:	x86
OS:	openSUSE 11.0
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	474647
Attachments:	Part of fix, with test

Description calen chen 2009-02-12 08:09:55 UTC

PROBLEM STATEMENT:

PopupButton is missing "showing" state 


REPRO:

1. run accerciser
2. run uia2atk/test/samples/openfiledialog.py, click "OpenDialog" button to
invoke OpenFileDialog, PopupButtonPanel with "Recently used", "Desktop",
"Personal" PopupButtons in this example
3. in accercuser, expand dialog, select PopupButton like "Desktop" from left tree, then see states under interface viewer

RESULTS:

PopupButton has states: [Enabled, Selectable, Sensitive, Visible]

EXPECTED RESULTS:

PopupButton is missing "showing" state

I don't think MenuItem in here is selectable, otherwise we should provide AtkSeletion for its parent Panel

so I think the correct states should be [[Enabled, Showing, Sensitive, Visible]

COMMENTS:

Comment 1 calen chen 2009-02-12 16:56:44 UTC

Add Comments:

Press Tab can focus to popupButtonPanel, then press keyDown/Up can move focus between popupButtons, so do you think we need provide "focusable" and "+-focused"?

Comment 2 Sanford Armstrong 2009-02-12 18:20:34 UTC

Good catch, Calen.  Taking bug.

Comment 3 Brad Taylor 2009-03-04 16:53:26 UTC

Sandy, can you update the estimate for this bug?  Thanks.

Comment 4 Brad Taylor 2009-03-04 19:40:31 UTC

P1s and P2s automatically go into Release 1.0.

Comment 5 Sanford Armstrong 2009-03-11 23:46:17 UTC

Frustratingly, focus change events do not work for PopupButton at this time.  Thanks for catching this; we'll need to patch MWF to make it work correctly.

As for removing Selectable/Selected, that seems to contradict the resolution of bug #457990.  Seems it was decided that all tool bar items would be marked Selectable, and would be marked Selected when focused.  Of course, I could be misunderstanding that part.

Will at least fix Focusable, which is not set due to a bug in our stuff.  Then all that is left to do is the MWF patch (and after Thursday I will file the MWF blocker bug).

Comment 6 Sanford Armstrong 2009-03-12 01:56:14 UTC

Created attachment 278976 [details]
Part of fix, with test

This at least makes the PopupButton show up as Focusable, and includes a test for the states.

Confused about a bunch of bridge test regressions I'm seeing (that seem unrelated to my patch), so holding off on committing this.

Comment 7 Sanford Armstrong 2009-03-12 16:17:31 UTC

Comment on attachment 278976 [details]
Part of fix, with test

Patch committed in r129154 of UIAutomationWinforms and UiaAtkBridge.

Comment 8 Sanford Armstrong 2009-03-12 16:18:09 UTC

Retargetting to 1.1 for rest of fixes, unassigning.

Comment 9 Brian Merrell 2009-06-05 02:20:35 UTC

This bug as it was originally described in the summary and description are fixed.  This bug is now tracking the lack of "focused" state for the PopopButton accessible.  I am changing the summary to indicate this, but we should open new bugs for situations like this in the future.