Bug 479397

Summary: ContextMenuStrip: ToolStripMenuItem is missing "focused" state when using AtkSelection.
Product: [Mono] UI Automation Reporter: Neville Gao <ngao>
Component: Winforms - GeneralAssignee: Andres Aragoneses <aaragoneses>
Status: VERIFIED FIXED QA Contact: E-mail List <mono-a11y-qa>
Severity: Normal    
Priority: P2 - High    
Version: Unspecified   
Target Milestone: Release 1.1   
Hardware: i686   
OS: openSUSE 11.1   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on: 495623    
Bug Blocks: 487654    
Attachments: pyatspi sample

Description Neville Gao 2009-02-25 07:39:17 UTC
Created attachment 275229 [details]
pyatspi sample

PROBLEM STATEMENT:

ToolStripMenuitem in ContextMenuStrip is missing "focused" state when using AtkSelection.


REPRO:

1. Run uia2atk/test/sample/contextmenustrip.py.
2. Run attached pyatspi sample.


RESULTS:

ToolStrip Menu Item 1 States: [STATE_ENABLED, STATE_SELECTABLE, STATE_SELECTED, STATE_SENSITIVE, STATE_SHOWING, STATE_VISIBLE]


EXPECTED RESULTS:

ToolStrip Menu Item 1 States: [STATE_ENABLED, STATE_SELECTABLE, STATE_SELECTED, STATE_SENSITIVE, STATE_SHOWING, STATE_VISIBLE, STATE_FOCUSED]
Comment 1 Brad Taylor 2009-03-04 15:44:48 UTC
I disagree with this, Neville.  Focused shouldn't show up unless the control actually has keyboard focus.  When calling selectChild(), the menu is not visible, and keyboard focus is not possible.  If GAIL is doing this, in my opinion, it's a bug.
Comment 2 Neville Gao 2009-03-05 03:30:56 UTC
Brad, in the attached pyatspi file, the first step is to open ContextMenu, then use  AtkSelection to select the child, so I think the menu is visible, and items need "focused" state.
Comment 3 Brad Taylor 2009-03-05 14:36:07 UTC
You're right, I was reading the test incorrectly.
Comment 4 Neville Gao 2009-03-10 03:57:57 UTC
This has been fixed in other bugs.
Comment 5 Neville Gao 2009-04-08 09:48:00 UTC
Reopened, this issue can be reproduced in trunk r131300.

This is related to bug 471405.
Comment 6 Andres Aragoneses 2009-04-25 01:08:33 UTC
I have a half-working patch for this bug, but it depends in:

* Knowing if it's correct that, in gail, a menuitem "Open" below "File" doesn't have a Focusable state _even_ when File is open. I'll check with Mike, which is the one that I guess has the latest gail version installed and running.
* The patch on bug 495623 to be applied.
Comment 7 Andres Aragoneses 2009-04-27 15:14:00 UTC
(In reply to comment #6)
> * Knowing if it's correct that, in gail, a menuitem "Open" below "File" doesn't
> have a Focusable state _even_ when File is open. I'll check with Mike, which is
> the one that I guess has the latest gail version installed and running.
> * The patch on bug 495623 to be applied.

Mike agrees, so I've reported upstream:

http://bugzilla.gnome.org/show_bug.cgi?id=580460
http://bugzilla.gnome.org/show_bug.cgi?id=580452
Comment 8 Andres Aragoneses 2009-05-11 20:54:21 UTC
Fixed in r133927.
Comment 9 Neville Gao 2009-05-12 10:04:37 UTC
Verified in trunk r133943. Closing.