Bug 53228 (suse38228)

Summary: Enhance pango to support artifical bold and italic
Product: [openSUSE] SUSE Linux 10.1 Reporter: Zhe Su <zsu>
Component: GNOMEAssignee: Holger Hetterich <hhetter>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P3 - Medium CC: aj, federico
Version: Alpha 1   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: The patch.
The updated patch for pango 1.10.1
gedit-font-selection-dialog-without-patch.png
gedit-font-selection-dialog-with-patch.png

Description Zhe Su 2004-04-04 00:24:08 UTC
This patch enhances pango to support artifical bold and italic.
Comment 1 Zhe Su 2004-04-04 00:24:40 UTC
Created attachment 17836 [details]
The patch.
Comment 2 Stanislav Brabec 2004-04-05 17:40:36 UTC
Is this patch intended for SuSE Linux 9.1 or for future versions and mainstream?
Comment 3 Ralf Flaxa 2004-04-30 18:23:31 UTC
This patch would be for SLS9, but only if we can add it without any risk 
and if it doesn't break any backward compatibility. 
Please comment, then assign to me for decision. 
 
Comment 4 Zhe Su 2004-04-30 18:40:11 UTC
This patch should be ok. It does not modify any API and the behavior of client
software. Indeed, the artifical bold and italic are supported in Xft, this patch
just adds the required information in order to let Xft do the right job.
Comment 5 Holger Hetterich 2004-04-30 20:10:46 UTC
I tried this patch. It applies cleanly; package is ready to be checked in.
Since it does not modify the API, I think positive to check it in.

Ralf, please make your decision.
Comment 6 Holger Hetterich 2004-04-30 20:55:21 UTC
I tested this patch together with the one from #38226, and it works.
Comment 7 Ralf Flaxa 2004-04-30 21:02:30 UTC
Ok, green light to submit to autobuild. 
Please mention the Bugzilla entry. 
Comment 8 Holger Hetterich 2004-04-30 21:10:49 UTC
Package submitted to SLES9
Comment 9 Zhe Su 2005-10-20 06:54:13 UTC
This bug is exist in SUSE 10.1. I'll post an updated patch for pango 1.10.1.
Comment 10 Zhe Su 2005-10-20 06:58:32 UTC
Created attachment 54869 [details]
The updated patch for pango 1.10.1

Please submit it to SUSE 10.1
Comment 11 Federico Mena Quintero 2005-11-23 22:33:08 UTC
The upstream people need to see this bug.  Can we make it public?
Comment 12 Zhe Su 2005-11-24 06:44:19 UTC
IMO, it should be ok.
Comment 13 Andreas Jaeger 2005-11-24 07:54:24 UTC
It's public now.
Comment 14 Zhe Su 2005-12-29 04:38:38 UTC
Do you have any update about this issue? Can we merge this patch into our pango package first?
Comment 15 Federico Mena Quintero 2005-12-29 18:49:06 UTC
If the patch works for you (and doesn't do things like faking bold/italic for fonts that *do* have them), feel free to add it to our package.  You'll need to ask Owen or Behdad upstream, as I'm not that familiar with the fontconfig API.
Comment 16 Zhe Su 2005-12-30 01:24:39 UTC
I'd like to help add that patch to our package. However, it's hard for me to access autobuild system because of the poor network connection in our office. The VPN client for Linux is always failed to connect to the vpn server. We are asking our IS&T engineer to help us setup the vpn connection on router, but it needs some time.

So could you please help add the patch?
Comment 17 Mike Fabian 2005-12-30 13:12:58 UTC
I submitted pango with the patch from Comment #10 to STABLE.
Comment 18 Mike Fabian 2005-12-30 13:15:13 UTC
Created attachment 61826 [details]
gedit-font-selection-dialog-without-patch.png

font selection dialog in gedit without the patch applied.
Only "Regular" is selectable for "FZSongTi".
Comment 19 Mike Fabian 2005-12-30 13:17:02 UTC
Created attachment 61827 [details]
gedit-font-selection-dialog-with-patch.png

font selection dialog in gedit without the patch applied.  "Regular",
"Italic", "Bold", and "Bold Italic" are selectable now for "FZSongTi".
Comment 20 Mike Fabian 2005-12-30 13:17:55 UTC
As I submitted the patched package to STABLE and verified that it works,
I am closing this bug as FIXED.