Bug 540627

Bubli? You probably know more details about "X-KDE-SubstituteUID" option...

Either we edit _ALL_ desktop files and replace X-KDE-SubstitudeUID with Andrea's suggestion (xdg-su -c cmd) or we hack the support into Xfce and LXDE. (We would still need to hack ALL new upcoming desktop environments ...)

(In reply to comment #2)
> Either we edit _ALL_ desktop files and replace X-KDE-SubstitudeUID with
> Andrea's suggestion (xdg-su -c cmd) 

That's the way to go IMHO. 

Finding all desktop files that contain X-KDE-SubstitudeUID should be easy with a rpmlint (or similar) check.

> or we hack the support into Xfce and LXDE.
> (We would still need to hack ALL new upcoming desktop environments ...)

That will cause more work on the long-term ;-) and additionally isn't a good[tm] solution. If you really want this way, ask upstream (freedesktop.org) to introduce a "SubstitudeUID" parameter that is valid for all desktops instead of making all desktop environments honoring KDE-specific settings.

(In reply to comment #0)
> Really, also GNOME as very famous DE understand that.

Not quite true, SUSE's fork of GNOME does, but upstream GNOME does not (that's what I was told some time ago, maybe it's not so anymore ... )

(In reply to comment #2)
> Either we edit _ALL_ desktop files and replace X-KDE-SubstitudeUID with
> Andrea's suggestion (xdg-su -c cmd) 

Fair enough, let's do it.

The only thing that bothers me is that YaST should somehow require/recommend xdg-utils in order to make sure 'xdg-su' is really installed and can be used. The question is 
i) which component of YaST ( yast2 - its base package, as every single YaST module depends on it? ) will be the one with requirement
ii) wouldn't strict requirement of xdg-utils pull in some additional (desktop-oriented) stuff we certainly want to avoid on minimal systems where YaST must also work?

1st question:

who's supposed to submitreq for ANY desktop file? any fast way to do it?

2nd

actually the following packages looks to REQUIRE xdg-utils:

desktop-data-openSUSE
dia
opensuse-codec-installer
wireshark
xsane
gtkpod

and looks to be already a MUST for patterns:

package-lists-openSUSE-X11-cd
package-lists-openSUSE-images


and anyway, icewm requires xdg-menu and i see no troubles if it can recommends xdg-utils

in other words, even minimum X11 installation should already have xdg-utils installed because of patterns.

any way the core component is just "yast2" so probably it should be added as recommends to yast2 package or to patterns..

(In reply to comment #4)

> i) which component of YaST ( yast2 - its base package, as every single YaST
> module depends on it? ) will be the one with requirement

Unless we have another yast package that is being installed for each module, yast2 seems to be the only choice.

> ii) wouldn't strict requirement of xdg-utils pull in some additional
> (desktop-oriented) stuff we certainly want to avoid on minimal systems where
> YaST must also work?

$ rpm -q --requires xdg-utils
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
/bin/bash
/bin/sh
rpmlib(PayloadIsLzma) <= 4.4.6-1

Seems that xdg-utils does not bring any unnecessary requires to system (at the moment). We'd need to track that if we added REQUIRES to yast2 core package.

(In reply to comment #5)
> who's supposed to submitreq for ANY desktop file? any fast way to do it?

I wouldn't create SRs right now. There would be hundreds of them. We could think of a better approach and probably also create RPMLINT check which will throw an error if "X-KDE-SubstituteUID" and suggest using "xdg-su -c" in Exec line instead.

Adding Coolo and Dirk for further discussion.

> 2nd
> in other words, even minimum X11 installation should already have xdg-utils
> installed because of patterns.

Good.

I've made a mass update of relevant .desktops for all YaST modules in our SVN repo (there are still some modules out there that are not living in this repo and are maintained outside YaST team, but afaik none of them is part of openSUSE)

After discussion with jsrain (he's maintaining yast2.rpm - the base pack every other YaST pack requires), we decided to go for adding a weak requirement to yast2, so it now Recommends: xdg-utils. On X11-enabled systems xdg-utils are in anyway. On X11-less systems we don't need them, as text-mode YaST control centre doesn't read Exec= key at all.

> > who's supposed to submitreq for ANY desktop file? any fast way to do it?
> 
> I wouldn't create SRs right now. There would be hundreds of them. 

Right, it's like ~80 YaST packages to submit. Some of them (storage, tv, ...)  are already submitted with the above mentioned change. The rest will get submitted over the time, due to other pending changes. Those that won't, might get a reminder in, say, 2 months from now ...

wonderful

(In reply to comment #8)
> > I wouldn't create SRs right now. There would be hundreds of them. 
> 
> Right, it's like ~80 YaST packages to submit.

Well, not only YaST uses desktop files. That's why I wrote "hundreds" ... But thanks for your effort in YaST territory.

what about to add the rpmlint check as pavol suggested? i don't think to be difficult.... i will try to create my own rpmlint, no promises :)

Who's the next candidate for .desktop file modification, now that YaST is done ?

anubis@linux-y9ev:/usr/share/applications> grep -rwl "X-KDE-SubstituteUID" .
./MonoOSC.desktop                                                           
./AcetoneISO.desktop                                                        
./gnome-system-log.desktop                                                  
./gparted.desktop                                                           
./sax2.desktop                                                              

./YaST2/*.desktop  --> already done

./wireshark.desktop


that has been done on my gnome 11.2 installation... of course lots of packages are not installed on my system and actually only wireshark, sax2 and gnome-system-log looks be OSS packages

I'll take it. Wireshark is mine package and I'll take care of the rest too.

FYI regarding comment #8:
"adding a weak requirement to yast2, so it now Recommends: xdg-utils.
 On X11-enabled systems xdg-utils are in anyway.
 On X11-less systems we don't need them"

In the end "Recommends: xdg-utils" lets our package mamagement system
install xdg-utils and anything which it requires in any case, see
https://bugzilla.novell.com/show_bug.cgi?id=546893#c4
-----------------------------------------------------------------
Recommends has in the end the same result as Requires
(if the packages are available to be installed) because
our installer installs recommended packages silently
-----------------------------------------------------------------

Fortunately (as far as I see) xdg-utils requires almost nothing.
In particular (as far as I see) xdg-utils does not require
or recommend any X11 stuff.

(In reply to comment #15)
> FYI regarding comment #8:
> "adding a weak requirement to yast2, so it now Recommends: xdg-utils.
>  On X11-enabled systems xdg-utils are in anyway.
>  On X11-less systems we don't need them"
> 
> In the end "Recommends: xdg-utils" lets our package mamagement system
> install xdg-utils and anything which it requires in any case, see
> https://bugzilla.novell.com/show_bug.cgi?id=546893#c4
> -----------------------------------------------------------------
> Recommends has in the end the same result as Requires
> (if the packages are available to be installed) because
> our installer installs recommended packages silently
> -----------------------------------------------------------------
> 
> Fortunately (as far as I see) xdg-utils requires almost nothing.
> In particular (as far as I see) xdg-utils does not require
> or recommend any X11 stuff.


exactly, it will never recommend/requires anything since it's just a set of wrapper scripts.

if do not want to recommend it, how do you suggest to proceed? simply work on patterns?

> if do not want to recommend it, how do you suggest to proceed? simply work on
> patterns?

Nah, what Johannes is probably trying to imply here is that with current default setup of libzypp and solver, there is no difference between Recommends and Requires. Package gets pulled in as a dependent one no matter which one of these two is used, so we could have done Requires:xdg-utils just as well.

This behaviour can be switched off in zypp.conf and then only Requires will be installed along with selected package/pattern. But I doubt many users know about and use this option.

i think than, that's better to leave it as Recommends, because IMHO you can still avoid to install xdg-utils with  the "--no-recommends" zypper option, that is much easier to find than edit zypp.conf

So, hrm, does that mean I can remove the patches we have in GNOME to support X-KDE-SubstituteUID?

(In reply to comment #19)
> So, hrm, does that mean I can remove the patches we have in GNOME to support
> X-KDE-SubstituteUID?

Let's keep them for a while. At least until there is a rpmlint check ready and active :-)

Fixed wireshark, sax2 and gparted package. Reassigning to GNOME so they can fix their desktop files, after that we should clean KDE.

perfect... any news from rpmlint check? it will help to fix all packages, even outside Factory

No news, someone has to write it :-/

(In reply to comment #21)
> Fixed wireshark, sax2 and gparted package. Reassigning to GNOME so they can fix
> their desktop files, after that we should clean KDE.

I fixed the only mention of a X-KDE-SubstitudeUID key in GNOME .desktop files I'm aware of.

So moving to kde team.

what's the current status of that ?

Update released for: yast2-add-on-creator
Products:
openSUSE 11.2 (i586)
openSUSE 11.3 (i586)

i guess it wasn't supposed to be here right?

(In reply to comment #26)
> Update released for: yast2-add-on-creator
> Products:
> openSUSE 11.2 (i586)
> openSUSE 11.3 (i586)

I don't have any mention of X-KDE-SubstitudeUID here anymore on 11.4. Can we go ahead and remove the patches in gnome-desktop and glib?

what about bnc621848 ??

they said the request for maintenance was sent, but i don't see any progress... 11.3 is still broken

the following .desktop files for yast are still broken:

add-on 
inetd
joystick
online_update
sshd
vendor
backup
inst_release_notes
ldap_browser
restore
sudo                
checkmedia
inst_suse_register
mouse
sound
sysconfig           
hwinfo
irda
nis
squid
system_settings

and only based on the ones i have installed... can you confirm it has been fixed on factory?

(In reply to comment #29)
> what about bnc621848 ??
> 
> they said the request for maintenance was sent, but i don't see any progress...
> 11.3 is still broken

As I said in my comment, I only looked at 11.4 (ie, Factory).

> the following .desktop files for yast are still broken:
> 
> add-on 

...

> system_settings
> 
> and only based on the ones i have installed... can you confirm it has been
> fixed on factory?

Nope, it has been fixed in YaST SVN only. Some modules are fixed in Factory, because mass update of .desktop files (removing SubstituteUID) got in along with other bugfixes. 
The above listed modules are still broken in Factory because nobody made submitreqs when there were no other bugfixes pending. And nobody (almost) hacks on YaST anymore

This problem is not YaST specific and affects many packages. So it should be supervised on the project management level.

if you submitted all fixed yast modules from svn, feel free to close it.

OK, then lets start with the first module. Lukas when you have submitted
your packages to factory please assign the bug to the next package maintainer:

add-on 
inetd
joystick
online_update
sshd
vendor
backup
inst_release_notes
ldap_browser
restore
sudo                
checkmedia
inst_suse_register
mouse
sound
sysconfig           
hwinfo
irda
nis
squid
system_settings

Any news on this? The patch we have in glib to try to support this in the meantime might be causing issues (see bug 681078).

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/73653 Factory / yast2-sshd

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/74667 Factory / yast2-squid

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/74761 Factory / yast2-add-on

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/75857 Factory / yast2-squid

All YaST modules I've found in SVN have been fixed

  * Removed X-KDE-SubstituteUID from desktp files
  * Replaced with /usr/bin/xdg-su -c '/sbin/yast2 ${yast_module}'
    if appropriate

I'll continue with submitting all the package as time permits next week...

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/76788 Factory / yast2

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/76800 Factory / yast2-network

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/76946 Factory / yast2-packager

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/76953 Factory / yast2-metapackage-handler
https://build.opensuse.org/request/show/76957 Factory / yast2-installation

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/76958 Factory / yast2-firstboot

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/77047 Factory / yast2-ldap-client

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/77063 Factory / yast2-devtools

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/77068 Factory / yast2-fcoe-client
https://build.opensuse.org/request/show/77072 Factory / yast2-snapper

All (known) YaST modules have been fixed. Most of them submitted
to openSUSE:Factory (if appropriate).

I'm now removing the patches in glib2 and gnome-desktop2 that change the code to understand X-KDE-SubstituteUID.

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/77079 Factory / yast2-apparmor

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/77221 Factory / yast2-sysconfig

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/80417 Factory / autoyast2

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/82417 Factory / yast2-restore
https://build.opensuse.org/request/show/82418 Factory / yast2-irda

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/85921 Factory / yast2-slp
https://build.opensuse.org/request/show/85926 Factory / yast2-mouse

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/85932 Factory / yast2-phone-services

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/86514 Factory / yast2-slp

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/37769 Factory / yast2-packager
https://build.opensuse.org/request/show/40018 Factory / yast2-http-server
https://build.opensuse.org/request/show/42198 Factory / yast2-slp-server
https://build.opensuse.org/request/show/42262 Factory / yast2-instserver
https://build.opensuse.org/request/show/42690 Factory / yast2-dirinstall
https://build.opensuse.org/request/show/49782 Factory / yast2-online-update
https://build.opensuse.org/request/show/49936 Factory / yast2-tune
https://build.opensuse.org/request/show/50376 Factory / yast2-live-installer
https://build.opensuse.org/request/show/52593 Factory / yast2-sound
https://build.opensuse.org/request/show/65008 Factory / yast2-nis-client
https://build.opensuse.org/request/show/77668 Factory / yast2-sudo
https://build.opensuse.org/request/show/78015 Factory / yast2-power-management
https://build.opensuse.org/request/show/78261 Factory / yast2-nis-server

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/520245 Factory / gparted

This is an autogenerated message for OBS integration:
This bug (540627) was mentioned in
https://build.opensuse.org/request/show/595936 Factory / yast2-iscsi-client