Bug 655483

Created attachment 401780 [details]
libproxy sysconfig support

This patchs adds support to sysconfig for libproxy.

There are two points that need review:

Right now, the module implements

	virtual bool operator<(const base_extension&) const {
            if (getuid == 0)
		return true;
            return false;            
	}

which means the plugin will be put first, if we run as root.

Also in the module loading macro:

MM_MODULE_INIT_EZ(sysconfig_config_extension, true, NULL, NULL);

It seems the true parameter needs to be replaced by a conditional for this module to be used, something if_exists?(/etc/sysconfig)

> MM_MODULE_INIT_EZ(sysconfig_config_extension, true, NULL, NULL);

i'd suggest replacing true with getuid() == 0; thus not going through the whole init if you're not root and invalidate the module completely for other users (which would have their own session normally).

1. a test function needs to be used instead of MM_MODULE_INIT_EZ(..., true) to determine if /etc/sysconfig/proxy exists.
2. getuid needs '()'
3. cleanup spacing to match our style (particularly around funcion calls)
4. Remove the left over comment (copy/paste) from envvar

Let me know when you've got these fixed and we'll merge upstream.

Nathaniel, I sent it upstream ( http://code.google.com/p/libproxy/issues/detail?id=150 )

I will post the updated version there.

Created attachment 401819 [details]
Updated patch

New version of the patch with suggestions.

Could not attach it in code.google.com

Dominique: do we want to include it in our package now?

I think that's certainly something we should do, yes...

Submitted to G:F (sr#54906).

Duncan: I don't know if there's anything else you want to track in this bug, or if your patch covers everything you needed. If the latter, then we can close the bug, I guess.

This can be closed for now.