Bug 768423

Summary:	mkinitrd: update sysconfig comments
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Jan Engelhardt <jengelh>
Component:	Basesystem	Assignee:	Olaf Hering <ohering>
Status:	VERIFIED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Enhancement
Priority:	P5 - None	CC:	ohering, ro
Version:	13.1 Milestone 2
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Found By:	Beta-Customer	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Jan Engelhardt 2012-06-22 15:39:39 UTC

Mention in /etc/sysconfig/kernel MODULES_LOADED_ON_BOOT that it is now superseded by /etc/modules-load.d/.

Comment 1 Olaf Hering 2013-07-11 18:37:42 UTC

Its still referenced in /etc/init.d/boot.loadmodules, is that file not exectued anymore in 12.3? If so, looks like a sysvinit handling bug in systemd, unless this particular file is masked somewhere.

Comment 2 Jan Engelhardt 2013-07-11 19:58:12 UTC

/etc/init.d/boot.loadmodules is masked by systemd (/usr/lib/systemd/system/loadmodules.service -> /dev/null), and systemd is default in 12.3, so by all practical considerations, boot.loadmodules is not executed anymore. openSUSE-systemd has a replacement service, systemd-load-modules.service, for reading the old MODULES_LOADED_ON_BOOT.

Comment 3 Olaf Hering 2013-07-15 17:41:33 UTC

I think its not easy to modify a comment of an existing, or remove an old variable. Rudi, what should be done with old variables or existing comments?

I would just remove boot.loadmodules and the fillup template from Factory.

Comment 4 Jan Engelhardt 2013-07-15 18:12:39 UTC

Editing the fillup template would be sufficient as far as the bug report is concerned. Of course, removal also sounds good.

Comment 5 Ruediger Oertel 2013-07-16 00:33:43 UTC

there is a macro to remove variables from sysconfig files, modifying comments is
not directly supported.

for reference:
# macro: remove_and_set
#      remove variables from sysconfig.$NAME
#      (both if existant) and set them in the environment
#      for further handling in postinstall
#  options: -n set package name
#           -y default to yes if not found (otherwise no)
%remove_and_set(n:y)
...

and yes, we should find a way to read the value and configure systemd accordingly
but in the end I'm afraid this will end like most things and we will just remove
the previous configuration :(

Comment 6 Olaf Hering 2013-07-16 13:59:38 UTC

(In reply to comment #2)
> /etc/init.d/boot.loadmodules is masked by systemd
> (/usr/lib/systemd/system/loadmodules.service -> /dev/null), and systemd is
> default in 12.3, so by all practical considerations, boot.loadmodules is not
> executed anymore. openSUSE-systemd has a replacement service,
> systemd-load-modules.service, for reading the old MODULES_LOADED_ON_BOOT.

What is the replacement for MODULES_LOADED_ON_BOOT? I guess there is no upgrade path implemented.

Comment 7 Jan Engelhardt 2013-07-16 14:30:34 UTC

There is no upgrade path implemented atm — which conversely means we will keep on reading MODULES_LOADED_ON_BOOT from /etc/sysconfig/kernel (but it is still deprecated ;-).

Comment 8 Olaf Hering 2013-07-16 15:52:34 UTC

http://www.freedesktop.org/software/systemd/man/modules-load.d.html

Looks like its as simple as writing a MODULES_LOADED_ON_BOOT.conf file to /etc/modules-load.d/ and remove the old setting somehow with the macro above.

Comment 9 Olaf Hering 2013-07-31 17:57:42 UTC

I commited such a change now.
https://gitorious.org/opensuse/mkinitrd/commit/5451b375e502b88a623fb0a47fbf75115f0acee6

Comment 10 Bernhard Wiedemann 2013-08-04 09:00:21 UTC

This is an autogenerated message for OBS integration:
This bug (768423) was mentioned in
https://build.opensuse.org/request/show/185826 Factory / mkinitrd