Bug 980292

Summary: Yast shouldn't allow running two instances of module at once
Product: [openSUSE] openSUSE Tumbleweed Reporter: Howard Guo <hguo>
Component: YaST2Assignee: YaST Team <yast-internal>
Status: NEW --- QA Contact: Jiri Srain <jsrain>
Severity: Enhancement    
Priority: P5 - None CC: hguo, hkuehnemund, jreidinger, ronazek, shundhammer
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
URL: https://trello.com/c/90wfBZ1G
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Howard Guo 2016-05-17 10:25:36 UTC
It's very easy to mistakenly double click on a module icon in Yast2, causing two instances of the module to be started, and there's absolutely no point in using more than one instance of any yast module.

Please disallow double click on yast2, and prevent more than one instance of module to be started.
Comment 1 Josef Reidinger 2016-05-17 12:32:44 UTC
added to yast task queue
Comment 2 Stefan Hundhammer 2016-05-18 09:28:44 UTC
IIRC I added support for catching double clicks in the control center a long time ago. I can still recall that there was a problem with switching to or from daylight savings time that would use a one-hour timeout in that case.

Anyway, forbidding running the same module twice would be WAY too drastic IMHO. What do you do when you have multiple admins on any machine, and one of them left a YaST module open while leaving for the day - and, worse, didn't come back because he got sick or went on vacation? Do you really want to hunt down running processes and identify them which module they run?

If double clicking in the control center really is the problem, then the control center has to take care of it - locally, in that one instance. IMHO it should already do that, but it can't hurt to check.

But let's not go completely over board with this.

Remember how many times Firefox complains about some old Firefox instance alledgedly still being active? And how many times this is just plain wrong? And Firefox does not even need to make a difference for different tasks for different instances - unlike YaST.

I strongly vote for not emulating that kind of brain dead^W^Wquestionable behaviour.
Comment 3 Howard Guo 2016-05-18 09:33:34 UTC
OK, if it is not forbidden to run two instances of a yast module simultaneously, can you agree that yast control centre should not launch more than one instance of a module at a time?
Comment 4 Lukas Ocilka 2016-09-07 08:00:17 UTC
And what if we just warn the user that the same Yast module already runs?
Comment 5 Howard Guo 2016-09-07 08:03:26 UTC
To me a displayed warning sounds like a reasonable resolution.
Comment 6 Stefan Hundhammer 2016-09-07 11:24:50 UTC
(In reply to Lukas Ocilka from comment #4)
> And what if we just warn the user that the same Yast module already runs?

That doesn't really change anything for the scenarios from comment #2. If anything, we'd need to offer the user to terminate that other YaST instance (e.g. send a SIGTERM, after a timeout a SIGKILL).

Otherwise we'd end up in the same unfortunate scenario as Firefox does so often: The application flatly refuses to start, and the user has to hunt down processes to terminate manually.
Comment 7 Ladislav Slezák 2022-01-07 09:01:24 UTC
*** Bug 1194352 has been marked as a duplicate of this bug. ***