Bug 104372 - consistent usage of yast2-country clients in autoyast configuration
Summary: consistent usage of yast2-country clients in autoyast configuration
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: YaST2 (show other bugs)
Version: Beta 1
Hardware: Other All
: P5 - None : Normal
Target Milestone: ---
Assignee: Uwe Gansert
QA Contact: Klaus Kämpf
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-12 12:01 UTC by Jiří Suchomel
Modified: 2005-11-15 12:08 UTC (History)
2 users (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
patch for autoinstallation/src/dialogs/general_dialogs.ycp (3.17 KB, patch)
2005-10-06 07:34 UTC, Jiří Suchomel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiří Suchomel 2005-08-12 12:01:12 UTC
yast2-country clients should be used consistently in autoyast configuration: now
some of them close the wizard windows and others don't (see #104231).

It could be fine to create *_auto.ycp clients so we could reach consistency with
 other YaST modules.
Comment 1 Jiří Suchomel 2005-08-12 12:01:57 UTC
Currently it works, so let's don't change it in beta phase but later for 10.1.
Comment 2 Jiří Suchomel 2005-09-29 12:13:58 UTC
reopened to start some work 
Comment 3 Jiří Suchomel 2005-10-04 14:06:41 UTC
hmm, inst_keyboard and inst_timezone are called from autoyast, but language
selection is done inside. 

Uwe, should I create _auto.ycp clients for all three parts? What should I output
from them?
Comment 4 Jiří Suchomel 2005-10-04 15:06:07 UTC
... for the language case, this would also add a possibility to configure
secondary languages.
Comment 5 Jiří Suchomel 2005-10-06 07:34:42 UTC
Created attachment 51569 [details]
patch for autoinstallation/src/dialogs/general_dialogs.ycp

This patch adds support for _auto clients of yast2-country, present there from
last (yast2-country-2.13.3) version.
Comment 6 Jiří Suchomel 2005-10-06 07:42:13 UTC
1. I'll assigne it to you so you can review the patch, check the result (sure, I
have testyed it myslef) and apply it to autoinstallation.

2. More work could be done:

a) support for secondary languages: in language_auto client and in autoyast schema

b) rewrite the _auto clients to be consistent with ususal _auto client API -
currently, these yast2-country clients are used only in config mode and are
always called with the same paramaters. They do not support the functions of
other _auto clients such as "Write", "Summary", etc. If you think I should force
them to use the standard API, reassign back to me. It could be useful even in
the case of supporting only one ("Change") function.
Comment 7 Uwe Gansert 2005-10-10 13:40:11 UTC
patch applied, thank you.
I'll come back to you for the final step (point b)
Comment 8 Uwe Gansert 2005-11-15 12:08:39 UTC
fixed for the next release.