Bug 104402 - cdc-acm (important patch for czech users)
Summary: cdc-acm (important patch for czech users)
Status: RESOLVED WONTFIX
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Kernel (show other bugs)
Version: Beta 1
Hardware: Other All
: P5 - None : Normal
Target Milestone: ---
Assignee: Greg Kroah-Hartman
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-12 13:55 UTC by Petr Ostadal
Modified: 2005-09-27 07:24 UTC (History)
2 users (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Ostadal 2005-08-12 13:55:26 UTC 
Hi,

a lot of people in czech rep. use cdma modem to connect to internet through
mobile  operator, but the driver in kernel has problem with speed, where the usb
modem doesn't exceed the speed ~256kbps, with the patch made by David Kubicek,
the speed increases over 730kbps.
The patch and mail thread is on linux-usb-devel
http://sourceforge.net/mailarchive/message.php?msg_id=12080364 .

But problem is that the patch has to be a litlle modify "to be nice for kernel",
but the author is maybe on holiday ;(. (all information about it are in the mail
thread http://sourceforge.net/mailarchive/message.php?msg_id=12106984). Bu t I
don't know nothing about usb in kernel and I can't do it by mysel, could some
one investigate it in suse and add it to our kernel? (I know a lot of people
from czech rep. will be happy ;)).

I tested the patch with kernel in SL9.3 and it works without problems.

The patch is on following address
http://dave.ok.cz/cdc-acm_release/linux-2.6.12-rc5_stable-cdc-acm.patch .
Comment 1 Greg Kroah-Hartman 2005-08-12 15:40:17 UTC 
No, that patch needs some work before it can go into mainline.

And we aren't accepting patches into our tree that are not already in mainline

And I don't want to maintain this patch outside of mainline.

So I'm going to reject this.
Comment 2 Petr Ostadal 2005-08-15 08:44:45 UTC 
Pavel, could you help with this? ;(
Comment 3 Vojtech Pavlik 2005-08-15 08:49:07 UTC 
The current maintainer of the cdc-acm driver is Oliver Neukum.
Please ask him to include the patch in the mainline, and then
we can talk about putting it into our kernel as well.
Comment 4 Pavel Machek 2005-08-15 12:46:49 UTC 
Olivier had some good comments on that patch. My additional comment is that the
patch combines 2 bugfixes and one speed fix in one patch... too bad.

Anyway, this is hard to patch without the hardware :-(.
Comment 5 Petr Ostadal 2005-09-23 21:31:16 UTC 
update: David Kubice ported patch to 2.6.13
(http://www.awk.cz/cdc-acm_release/linux-2.6.13.2_stable-cdc-acm.patch) and
Olivier has accepted it. The patch will be in kernel 2.6.14 .
Comment 6 Greg Kroah-Hartman 2005-09-27 07:24:21 UTC 
No, that patch has not been accepted yet, and will not go into 2.6.14 at
such a late date as it has not been sent to the Linux USB maintainer for submission.