Bug 105301 - yast-powermanagement: wrong default settings for powersave
Summary: yast-powermanagement: wrong default settings for powersave
Status: RESOLVED FIXED
: 113175 (view as bug list)
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: YaST2 (show other bugs)
Version: Beta 2
Hardware: Other All
: P5 - None : Critical
Target Milestone: ---
Assignee: Jiri Srain
QA Contact: Klaus Kämpf
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-17 18:34 UTC by Danny Al-Gaaf
Modified: 2005-08-26 11:58 UTC (History)
4 users (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Danny Al-Gaaf 2005-08-17 18:34:43 UTC 
The config files of powersave changed in SUSE 10.0. Seife 'removed' many default 
settings in the files in /etc/sysconfig/powersave, which now are empty in the 
files and filled in powersave with default settings if they are empty. The 
default value could be found in the comments in the files.

Problem: the yast-powermanagement module reads this empty config values and 
don't know the correct default settings. By this the module display and set 
wrong settings with the first call and close with accept changes. The module 
must be changed for this behavior.
Comment 1 Jiri Srain 2005-08-18 06:50:28 UTC 
Don't understand why you did this change. This obviously means that the 
default values have to be stored at two places - once in the file, and once in 
the powersave binary. What's the benefit?
Comment 2 Thomas Renninger 2005-08-18 07:34:34 UTC 
The benefit is to better update/change settings.
We now can change the default settings behind the back of the end user without any :

if version < 9.3
  sed s//
elseif version < 10.0
  sed s//
...

You just have the default settings of the version you installed.
The idea is really nice, however it seems as if Seife did not think about the
Yast counter part ...
Comment 3 Jiri Srain 2005-08-18 08:02:28 UTC 
OK, also if the value is an empty string, then I will use the default from the 
comment, right? It shouldn't be that big problem...
Comment 4 Jiri Srain 2005-08-18 08:32:12 UTC 
Please, fix the comments in the files so that I can use them first. 
 
There must be a colon after the 'Default' keyword, otherwise it won't work.
Comment 5 Danny Al-Gaaf 2005-08-18 08:41:58 UTC 
Thomas: could you fix this?!
Comment 6 Thomas Renninger 2005-08-25 13:23:57 UTC 
sorry for the delay.
Package submitted to stable.
Comment 7 Jiri Srain 2005-08-25 13:35:08 UTC 
OK, reopenning...
Comment 8 Jiri Srain 2005-08-25 13:35:35 UTC 
... and reassigning to me to take care of the default values.
Comment 9 Danny Al-Gaaf 2005-08-26 08:01:09 UTC 
*** Bug 113175 has been marked as a duplicate of this bug. ***
Comment 10 Jiri Srain 2005-08-26 11:58:53 UTC 
Fixed in SVN, submitting to STABLE in a moment.