Bug 105468 - embed kpdf into firefox (using dragonegg) by default
Summary: embed kpdf into firefox (using dragonegg) by default
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: KDE (show other bugs)
Version: Beta 2
Hardware: Other All
: P2 - High : Normal
Target Milestone: ---
Assignee: Stefan Dirsch
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-18 11:59 UTC by Marcus Meissner
Modified: 2005-08-30 21:12 UTC (History)
3 users (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
patch (754 bytes, patch)
2005-08-22 00:05 UTC, Dirk Mueller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Meissner 2005-08-18 11:59:56 UTC
to get rid of acrobat reader in the default selection we need to  
be able to reliably view PDFs in Firefox.  
  
Dirk, can you integrate kpdf (?) into firefox so that it started by default?  
  
We will need to do the same with gnome and gpdf or evince there.
Comment 1 Dirk Mueller 2005-08-22 00:05:11 UTC
Created attachment 46798 [details]
patch

this diff should do it, but I'm hesistant to submit as the package is broken
right now and I cannot test it..
Comment 2 Wolfgang Rosenauer 2005-08-22 04:19:56 UTC
without having any clue about dragonegg I understand that it will then *always*
use kpdf for PDFs? How about all other types which are supported through
dragonegg? I have tested it with both plugins installed now (acroread/dragonegg)
and Firefox just displays nothing now!
Comment 3 Dirk Mueller 2005-08-22 13:35:48 UTC
you probably don't have kpdf installed ? 
 
 
Comment 4 Dirk Mueller 2005-08-24 03:17:51 UTC
Wolfgang?  
 
anyway, I fixed this issue. it will only advertise pdf portability if kpdf is 
installed in the system. also fixed some crashes and braindamage (netscape 
plugins were loaded via the nsplugin kpart which was embedded in dragonegg) 
as well.  
 
there is still a problem about priotizing acrobat if installed. according to 
mozilla documentation mimetype handlers are registered on 
first-come-first-serve base, so the order of initialisation matters which one 
is registered first.  
 
to make matters worse, mozilla caches the mtimes of the plugins and only 
re-requests mime type information if mtime changed. therefore, libdragonegg.so 
has to be touched after kpdf or acrobat is installed.  
 
either that, or let the user sort that out (user can disable plugins on a 
mimetype base).  
 
opinions? 
 
 
 
 
  
Comment 5 Dirk Mueller 2005-08-28 20:35:29 UTC
ok, can I check in the dragonegg plugin linking patch? yes or no? 
 
any reaction would be nice.. 
 
Thanks! 
Comment 6 Wolfgang Rosenauer 2005-08-29 04:16:46 UTC
(In reply to comment #4)

Yes, most probably kpdf wasn't installed at that time.

> anyway, I fixed this issue. it will only advertise pdf portability if kpdf is 
> installed in the system. also fixed some crashes and braindamage (netscape 
> plugins were loaded via the nsplugin kpart which was embedded in dragonegg) 
> as well.  
>
> there is still a problem about priotizing acrobat if installed. according to 
> mozilla documentation mimetype handlers are registered on 
> first-come-first-serve base, so the order of initialisation matters which one 
> is registered first.  
>  
> to make matters worse, mozilla caches the mtimes of the plugins and only 
> re-requests mime type information if mtime changed. therefore, libdragonegg.so 
> has to be touched after kpdf or acrobat is installed.  
>  
> either that, or let the user sort that out (user can disable plugins on a 
> mimetype base).  
>  
> opinions? 

That's not easy :-( You are right about the mozilla plugin behaviour.
But the plugins are registered at least at every startup?
I don't have a big problem if the user installs kpdf and firefox doesn't
recognize it immediately but after the next restart.

(In reply to comment #5)
> ok, can I check in the dragonegg plugin linking patch? yes or no? 
>  
> any reaction would be nice.. 

Firefox on beta3 should already add dragonegg to its plugin list. The patch
within this bug (and some missing change) is already there.
Comment 7 Dirk Mueller 2005-08-29 17:20:55 UTC
ok, great, then reassigning to stefan for fixing the selection.  
 
 
Comment 8 Stefan Dirsch 2005-08-29 22:04:46 UTC
So what should be fixed exactly in selection? 
Comment 9 Adrian Schröter 2005-08-30 05:14:32 UTC
add dragonegg package to default selection in KDE. 
Comment 10 Stefan Dirsch 2005-08-30 21:12:40 UTC
fixed for RC1.