Bug 1116052 - Please convert SysV init scripts by wondershaper into native systemd services
Please convert SysV init scripts by wondershaper into native systemd services
Status: RESOLVED FIXED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Network
Current
Other Other
: P5 - None : Normal (vote)
: ---
Assigned To: Jiri Bohac
E-mail List
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-11-14 16:43 UTC by Franck Bui
Modified: 2019-06-03 09:23 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Franck Bui 2018-11-14 16:43:23 UTC
It would be great if the SysV init scrips shipped by this package could
be converted into systemd native services.

Indeed most packages shipped by openSUSE Factory switched to native
systemd unit files years ago and we plan to drop the obsolete/limited
SysV compat support in the future.

If this appears to be a big task, one quick way to solve it is to copy
and ship (as is) the .service unit wrappers generated automatically by
systemd-sysv-generator at boot. Indeed such wrappers are generated by
systemd in order to support SysV init scripts similarly to native
units.

You can see the content of a wrapper unit with:

 $ systemctl cat <sysvinit-script>.service

As you could see the wrapper unit simply calls the SysV script, which
should be moved out of /etc/init.d, probably in a directory owned by
your package.

In all cases we would be glad to provide any help if needed in this
task.

Thanks in advance.
Comment 1 Josef Möllers 2019-03-20 09:53:43 UTC
See https://build.opensuse.org/request/show/686892
Comment 2 Alexander Shchadilov 2019-05-31 13:13:41 UTC
Do I understand correctly that this bug is IN_PROGRESS because changes were brought to Tumbleweed but Leap is also planned? I am not sure how to work with wondershaper in recently released Leap 15.1 and was thinking if a bug report for Leap is needed; that is was I get after installation:

sudo systemctl enable wondershaper.service
wondershaper.service is not a native service, redirecting to systemd-sysv-install.
Executing: /usr/lib/systemd/systemd-sysv-install enable wondershaper

sudo systemctl start wondershaper.service
Job for wondershaper.service failed because the control process exited with error code.
See "systemctl  status wondershaper.service" and "journalctl  -xe" for details.

systemctl status wondershaper.service
● wondershaper.service - LSB: wondershaper providing QOS
   Loaded: loaded (/etc/init.d/wondershaper; generated; vendor preset: disabled)
   Active: failed (Result: exit-code) since Fri 2019-05-31 16:07:37 MSK; 1min 17s ago
     Docs: man:systemd-sysv-generator(8)
  Process: 23497 ExecStart=/etc/init.d/wondershaper start (code=exited, status=1/FAILURE)
Comment 3 Franck Bui 2019-06-03 06:59:11 UTC
(In reply to Alexander Shchadilov from comment #2)
> Do I understand correctly that this bug is IN_PROGRESS because changes were
> brought to Tumbleweed but Leap is also planned? 

Nope only Tumbleweed is targeted.

Josef, can this bug be closed now ?
Comment 4 Josef Möllers 2019-06-03 07:44:47 UTC
(In reply to Franck Bui from comment #3)
> (In reply to Alexander Shchadilov from comment #2)
> > Do I understand correctly that this bug is IN_PROGRESS because changes were
> > brought to Tumbleweed but Leap is also planned? 
> 
> Nope only Tumbleweed is targeted.
> 
> Josef, can this bug be closed now ?

Yes, by all means. The submit request
https://build.opensuse.org/request/show/686892
was accepted.
Comment 5 Josef Möllers 2019-06-03 09:23:05 UTC
SR Was accepted, so closing.