Bug 1128196 - gnome-settings-daemon -- Patches needs dropping or rebase
Summary: gnome-settings-daemon -- Patches needs dropping or rebase
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: xiaoguang wang
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1128190
  Show dependency tree / graph
 
Reported: 2019-03-06 16:48 UTC by Bjørn Lie
Modified: 2019-03-20 09:11 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: Yes
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bjørn Lie 2019-03-06 16:48:18 UTC 
Patches in gnome-settings-daemon needs dropping or rebase
Comment 1 Yifan Jiang 2019-03-20 02:01:45 UTC 
Hi Xiaoguang,

I assume this is mostly on the GNOME:Next which applies to GNOME 3.32.

The target feature implemented in gnome-settings-daemon-touch-screen-switch.patch, which is in need of re-base, seems moving to mutter.

https://gitlab.gnome.org/GNOME/gnome-settings-daemon/commit/104c5e603efe52b51dd1d392a2d6fb32142770bc

Would you help on it please.

btw. shall we completely remove the patch and open a new bug for mutter (if mutter does not have the feature by nature)?

Thank you!
Comment 2 xiaoguang wang 2019-03-20 02:34:25 UTC 
(In reply to Yifan Jiang from comment #1)
> Hi Xiaoguang,
> 
> I assume this is mostly on the GNOME:Next which applies to GNOME 3.32.
> 
> The target feature implemented in
> gnome-settings-daemon-touch-screen-switch.patch, which is in need of
> re-base, seems moving to mutter.
> 
> https://gitlab.gnome.org/GNOME/gnome-settings-daemon/commit/
> 104c5e603efe52b51dd1d392a2d6fb32142770bc
> 
> Would you help on it please.
> 
> btw. shall we completely remove the patch and open a new bug for mutter (if
> mutter does not have the feature by nature)?
> 
> Thank you!

I think we can remove this patch. The function has been added in mutter.
https://gitlab.gnome.org/GNOME/mutter/commit/d30301c00a6e884d1ccff4765d93c17e22ee2fc3
Comment 3 xiaoguang wang 2019-03-20 09:11:55 UTC 
Finished.