Bug 1128934 - Update libgda to current version 5.2.8
Summary: Update libgda to current version 5.2.8
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Felix Zhang
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1128190
  Show dependency tree / graph
 
Reported: 2019-03-12 15:10 UTC by Bjørn Lie
Modified: 2019-04-12 07:44 UTC (History)
3 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bjørn Lie 2019-03-12 15:10:24 UTC 
As summary says, update libgda to current version 5.2.8
Comment 1 Yifan Jiang 2019-03-20 04:27:40 UTC 
Just to avoid duplicated work, I had something in
home:yfjiang:branches:GNOME:Factory/libgda 

 libgda-5.2.4-nojavah.patch
 libgda-utf.patch 

I have finished the libgda directory similar with dimstar did before.

Meanwhile, I created libgda-5.2.8-nojavah.patch trying to
rebase libgda-5.2.4-nojavah.patch, but not 100% sure if it is correct:

https://build.opensuse.org/package/view_file/home:yfjiang:branches:GNOME:Factory/libgda/libgda-5.2.8-nojavah.patch
Comment 2 Yifan Jiang 2019-03-20 04:29:09 UTC 
> Meanwhile, I created libgda-5.2.8-nojavah.patch trying to
> rebase libgda-5.2.4-nojavah.patch, but not 100% sure if it is correct:
> 
> https://build.opensuse.org/package/view_file/home:yfjiang:branches:GNOME:
> Factory/libgda/libgda-5.2.8-nojavah.patch

Hi Fridrich,

Would you mind to take a quick review of the java compiling patch please? Thank you!
Comment 3 Yifan Jiang 2019-03-20 04:30:49 UTC 
In addition, the build is failed all the way, which could be related with other issues.
Comment 4 Yifan Jiang 2019-03-22 04:35:05 UTC 
Together with some tuning of spec and configure options, a successful build of 5.2.8 happened in:

https://build.opensuse.org/package/show/home:yfjiang:branches:GNOME:Factory/libgda

However Felix pointed out adding BuildRequires of postgresql-server-devel to provide the pg_config executable might not be ideal through discussions in bsc#1120035.

Felix is kindly offer the help to take over this, so set the assignee now :-)
Comment 5 Dominique Leuenberger 2019-04-09 11:56:50 UTC 
(In reply to Yifan Jiang from comment #1)
> Just to avoid duplicated work, I had something in
> home:yfjiang:branches:GNOME:Factory/libgda 
> 
>  libgda-5.2.4-nojavah.patch
>  libgda-utf.patch 
> 
> Meanwhile, I created libgda-5.2.8-nojavah.patch trying to
> rebase libgda-5.2.4-nojavah.patch, but not 100% sure if it is correct:

the nojavah patch is basically merged in 5.2.8 - there is only one minor thing missing (which was added in git post 5.2.8 release). So all you need in place of the nojavah.patch is https://github.com/GNOME/libgda/commit/10d43ce6aea0a041a776445783b4e1ca09651f57


>  libgda-utf.patch 

This patch might no longer be needed at all - or there might be better solution than carrying this patch around (rebasing it would be simple in any case)
Comment 6 Yifan Jiang 2019-04-11 00:42:43 UTC 
Thank you Dominique and Felix for helping out! I guess this bug can be closed?
Comment 7 Dominique Leuenberger 2019-04-12 07:44:59 UTC 
libgda has been updated to 5.2.8 and submitted to Factory