Bug 113005 - nautilus 'My Computer': confused ...
Summary: nautilus 'My Computer': confused ...
Status: RESOLVED FIXED
: 114324 (view as bug list)
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Beta 3
Hardware: Other All
: P5 - None : Normal
Target Milestone: ---
Assignee: Gary Ekker
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-25 15:08 UTC by Michael Meeks
Modified: 2005-09-08 15:48 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
photo (20.81 KB, image/png)
2005-08-25 15:09 UTC, Michael Meeks 		Details
hwinfo (169.08 KB, application/octet-stream)
2005-08-25 15:10 UTC, Michael Meeks 		Details
Proposed fix! (3.29 KB, patch)
2005-08-25 20:33 UTC, Robert Love 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2005-08-25 15:08:56 UTC 
My machine (hwinfo attached) has 1 DVD reader, and 1 CD read/writer (AFAICS) -
either way the 'My computer' view manages to turn that into 4 apparent devices -
which is slightly unusual. Harmless but strange I guess.
Comment 1 Michael Meeks 2005-08-25 15:09:36 UTC 
Created attachment 47569 [details]
photo
Comment 2 Michael Meeks 2005-08-25 15:10:02 UTC 
Created attachment 47570 [details]
hwinfo
Comment 3 JP Rosevear 2005-08-25 18:11:13 UTC 
I suspect this is hal providing 2 and fstab providing 2.
Comment 4 Robert Love 2005-08-25 19:12:51 UTC 
The Cheetah is on the case.
Comment 5 Robert Love 2005-08-25 20:33:30 UTC 
Created attachment 47665 [details]
Proposed fix!

Seriously, I am the Golden Cheetah.
Comment 6 Robert Love 2005-08-25 20:35:16 UTC 
Problem was as jpr described: gnome-vfs was pulling from both HAL and fstab.

But a little more subtle: gnome-vfs usually checks both and won't duplicate, but
we use symlinks like "/dev/cdrom" and HAL would report not knowing those, as HAL
deals in the actual device node only.  Fix is to use readlink(2) to resolve the
link, clean it up, and ask HAL about that, too.
Comment 7 Michael Meeks 2005-08-25 20:37:57 UTC 
So - another thing - does HAL report capabilities that we then subsequently use
? ie. if we have 2 reports of the same device: "can play DVDs" vs. "can record
CDs" - do we choose 1 at random, or correctly aggregate this set - or - are we
lame enough to not really care in this code ? :-)

Anyhow - thanks for the fix ;-)
Comment 8 Robert Love 2005-08-25 20:38:14 UTC 
Patch submitted upstream.  Track via b.g.o #314490.

We need to patch our gnome-vfs2 package, though, if they do not take this before
2.12.
Comment 9 Robert Love 2005-08-25 20:38:59 UTC 
#7: Yes, it reports sets of capabilities in an API-usable fashion.
Comment 10 Robert Love 2005-08-29 13:51:41 UTC 
b.g.o bug ##314490 says that this bug was merged upstream, before 2.12 was
released.  So we can pull this fix in in the final gnome-vfs package.  Otherwise
we need to merge this patch ...
Comment 11 JP Rosevear 2005-08-29 15:01:40 UTC 
Gary can pick this up in 2.12 then.
Comment 12 JP Rosevear 2005-08-31 12:23:07 UTC 
*** Bug 114324 has been marked as a duplicate of this bug. ***
Comment 13 Gary Ekker 2005-09-08 15:48:09 UTC 
We have the 2.12.0 version of gnome-vfs now, marking fixed.