Bug 113257 - SuSEconfig.kdm3 using excessive time
Summary: SuSEconfig.kdm3 using excessive time
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: KDE (show other bugs)
Version: Beta 3
Hardware: Other All
: P5 - None : Critical
Target Milestone: ---
Assignee: E-mail List
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-26 10:39 UTC by Ruediger Oertel
Modified: 2005-08-27 08:59 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ruediger Oertel 2005-08-26 10:39:08 UTC 
I times the usage of SuSEconfig modules on a multiple run (taking 
a bit of time on a firest run is tolerated, a rerun should better 
not be above 1 second). 
 
SuSEconfig.kdm3 has exactly one problem: 
Executing /sbin/conf.d/SuSEconfig.kdm3... 
 
real    0m20.443s 
user    0m0.036s 
sys     0m0.292s 
 
 
which is caused by "lilo -q". 
 
proposed fix: 
--- /sbin/conf.d/SuSEconfig.kdm3~       2005-08-26 12:33:12.000000000 +0200 
+++ /sbin/conf.d/SuSEconfig.kdm3        2005-08-26 12:33:21.000000000 +0200 
@@ -148,7 +148,7 @@ 
 fi 
 
 LILOCMD="-e s/^UseLilo=.*/UseLilo=false/" 
-if test -x /sbin/lilo; then 
+if test -x /sbin/lilo -a -f /etc/lilo.conf ; then 
    /sbin/lilo -q > /dev/null 2>&1 
    if test "$?" = 0; then 
        LILOCMD="-e s/^UseLilo=.*/UseLilo=true/"
Comment 1 Ruediger Oertel 2005-08-26 10:41:47 UTC 
up to critical ...
Comment 2 Dirk Mueller 2005-08-27 08:35:43 UTC 
looks good to me besides the -f /etc/lilo.conf .. what about if /etc/lilo.conf 
is a symlink to one of a set of alternative lilo.conf configurations (the user 
could have set up something like that) ? 
 
perhaps -e or -r would be enough.
Comment 3 Stephan Kulow 2005-08-27 08:59:00 UTC 
-f follows the symlink - and Adrian checked in the patch and left the bug open 
(old habits never die)