Bug 113548 - shpchp module loaded even on laptop
Summary: shpchp module loaded even on laptop
Status: RESOLVED WONTFIX
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Kernel (show other bugs)
Version: Beta 3
Hardware: Other All
: P5 - None : Minor
Target Milestone: ---
Assignee: Greg Kroah-Hartman
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-27 14:38 UTC by Andreas Jaeger
Modified: 2008-06-25 09:52 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Jaeger 2005-08-27 14:38:59 UTC
lsmod |grep shpchp shows:
shpchp                 88676  0
pci_hotplug            26164  1 shpchp

But my laptop has no pci hotplug capability at all.  Why is this loaded?
Comment 1 Greg Kroah-Hartman 2005-09-09 23:00:25 UTC
Because that's the way the driver shows it self "can accept any pci bridge device"

I'd suggest just blacklisting it, or unloading it, it's harmless.
Comment 2 Andreas Jaeger 2005-09-10 08:02:53 UTC
Should we black list it in general - or is this something I should do just on my
system?
Comment 3 Greg Kroah-Hartman 2005-09-12 16:53:24 UTC
Well, 99% of the systems will not have this chip, but for that 1% that do, 
blacklisting it in general will cause those users to be upset.

So, for your system, yes, you should blacklist it.  For any laptop, yes.

I don't know what the rules are for blacklisting stuff in general though.
Comment 4 Andreas Jaeger 2005-11-24 10:24:18 UTC
Hannes, any ideas?
Comment 5 Hannes Reinecke 2005-11-24 10:58:57 UTC
Can't we be a bit smarter here?
Are there any information in the PCI config which could help us?

In general, of course we could blacklist it; just add a line

alias shpchp = off

to /etc/modprobe.conf.

Not very selective, though.

The smarter way would be to have a hwcfg file for this slot, ie

hwcfg-bus-pci-0000.00:13.0

with just the lines:
STARTMODE='boot'
MODULE=''

in it. That would prevent the loading of any module for this specific slot.
Of course, this would mean YaST has to write it. And knowing how stretched the YaST resources are I doubt we're getting this ...

Greg, how does this driver know whether it can do anything sensible here?
Does it even know that?
Comment 6 Christian Zoz 2005-11-24 12:08:42 UTC
Don't use
  alias shpchp = off
but
  blacklist shpchp
Then it won't just be loaded automatically but a hwcfg-* would make it loaded.

The problem is that with udev_log=err (default) you won't see the message that this module is blacklisted. You only see it with udev_log=info.

Does it do any harm if it is loaded?
Comment 7 Greg Kroah-Hartman 2005-11-28 20:01:02 UTC
No, it doesn't do any harm if it is loaded.

I'll see if I can change the driver to only let it load when needed, instead
of for every pci bridge...
Comment 8 Greg Kroah-Hartman 2006-02-21 22:43:11 UTC
Is not going to happen for SLES10
Comment 9 Stephan Kulow 2008-06-25 09:32:52 UTC
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Comment 10 Stephan Kulow 2008-06-25 09:34:16 UTC
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Comment 11 Stephan Kulow 2008-06-25 09:40:45 UTC
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Comment 12 Stephan Kulow 2008-06-25 09:52:29 UTC
Closing old LATER+REMIND bugs as WONTFIX - if you still plan to work on it, feel free to reopen and set to ASSIGNED.

In case the report saw repeated reopen comments, it's due to bugzilla timing out on the huge request ;(