Bug 1136296 - sw_single falls back to `package` icon instead of `package-*`
sw_single falls back to `package` icon instead of `package-*`
Status: CONFIRMED
: 1136297 (view as bug list)
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: YaST2
Current
Other Other
: P5 - None : Normal (vote)
: ---
Assigned To: YaST Team
Jiri Srain
https://trello.com/c/srgCNI0i
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-26 06:11 UTC by Felix Miata
Modified: 2019-08-08 13:32 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
sw_single screenshot (76.80 KB, image/png)
2019-05-26 06:11 UTC, Felix Miata
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Miata 2019-05-26 06:11:20 UTC
Created attachment 805991 [details]
sw_single screenshot

Original summary:
sw_single falls back to `package` icon instead of `package-*`

In https://lists.opensuse.org/yast-devel/2019-05/msg00024.html Stasiek asked me to file this.
Comment 1 Felix Miata 2019-05-26 06:23:56 UTC
*** Bug 1136297 has been marked as a duplicate of this bug. ***
Comment 2 Martin Vidner 2019-05-27 09:13:22 UTC
Sorry, I don't understand what the problem is. Even at the user visible level.
Stasiek, can you either take this bug or explain what we can do about it?

Also, in the linked email, the screenshot* is blocked by our corporate firewall :-/
Please attach it here.

*) http://fm.no-ip.com/SS/Suse/YaST/TW/yastTW-plasma-201905-0768-swsingle3tabs.png
Comment 3 Sasi Olin 2019-05-27 09:52:37 UTC
From users pov, in some cases the package status icons will all be the same, `package` icon, which is not good if you are trying to perform anything in the interface.

What can we do about it? Install the icons in hicolor again so they actually exist just in case...

This **should** fix it, the preference of Qt icon fromTheme function iirc first checks if the icon name exists in the theme or fallback, and then attempts to split on `-`

Basically reverting the https://github.com/libyui/libyui-qt-pkg/commit/1b20767a83b4ae77da1df9e9823dc6dac896d674#diff-28ef1efacc3b75b586c9fa443adb2214L22 change.

However please check it, Qt icon loader tends to be unpredictable :/
Comment 4 Felix Miata 2019-05-27 12:13:45 UTC
(In reply to Martin Vidner from comment #2)
> Also, in the linked email, the screenshot* is blocked by our corporate
> firewall :-/
> Please attach it here.
 
> *)
> http://fm.no-ip.com/SS/Suse/YaST/TW/yastTW-plasma-201905-0768-swsingle3tabs. png

That is the same screenshot attached to this bug.
Comment 5 José Iván López González 2019-07-22 12:52:38 UTC
Stasiek, do you think this bug still applies? In such case (IIUC) you proposes to revert these changes from you [1]. Am I right?

[1] https://github.com/libyui/libyui-qt-pkg/commit/1b20767a83b4ae77da1df9e9823dc6dac896d674#diff-28ef1efacc3b75b586c9fa443adb2214L22
Comment 6 Sasi Olin 2019-07-22 19:08:42 UTC
That's not a solution, the way to fix this would be to check the https://doc.qt.io/qt-5/qicon.html#name matches full icon name, and only then use the icon from the theme.
Comment 7 José Iván López González 2019-08-08 13:28:23 UTC
Stasiek, thanks for the answer. Please, next time remember to click the "I am providing the requested information ..." checkbox to place the card under our radar again. Thanks!